RE: [PATCH 1/2] gdb: Allow address space qualifier parsing in C++.

["Willgerodt, Felix via Gdb-patches" <gdb-patches@sourceware.org>]

>-----Original Message-----
>From: Simon Marchi <simon.marchi@polymtl.ca> 
>Sent: Freitag, 2. April 2021 18:49
>
>Hi Felix,
>
>I think it would be valuable to have a test like this.  It's better than nothing, and it's always good to check error cases to make sure
>GDB doesn't crash on them.  I can imagine that this test could test with both a C and C++ program to cover everything correctly (and
>maybe other languages, but I don't know much about them, if that even applies to them).
>
>A while ago I added a simavr board file, to be able to run tests against an AVR target.  simavr is easy to build and use (it may even be
>packaged in distros, but I'd be tempted to use the latest available version).
>All of this to say you could try to run and improve the flash qualifier test for AVR (or write a new test).
>
>There's just one thing, avr-gcc/avr-g++ seem to produce stabs by default, it's not really useful to test with stabs nowadays.  I had a
>patch to make that board use dwarf by default (see below), but I never got around to try it properly and post it.  I'll try to do it soon
> (but you can apply it locally in the mean time).
>
>Simon

I think we are mixing my two patches a bit here, which is of course understandable as they are somewhat related.
However, avr-g++ didn't compile a program using __flash when I tried:
"error: '__flash' does not name a type"
I assume that support is only implemented in avr-gcc and I therefore can't even write an avr test for patch 1.

I opted for writing a general C and C++ test for patch 1, that has the advantage that every normal testsuite run has the chance to catch regressions.

Thanks for all the comments, I will push v2 in a couple of minutes.

Felix

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928