From: "Martin Liška" <mliska@suse.cz>
To: Luis Machado <luis.machado@linaro.org>,
Alan Modra <amodra@gmail.com>, Tom Tromey <tom@tromey.com>,
Alan Modra via Binutils <binutils@sourceware.org>,
gdb-patches@sourceware.org
Cc: "Thomas Weißschuh" <thomas@t-8ch.de>
Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ.
Date: Wed, 31 Mar 2021 15:12:22 +0200 [thread overview]
Message-ID: <f8f4d5d6-f3d7-6884-be78-a458beac9c28@suse.cz> (raw)
In-Reply-To: <b976b345-8b01-d6f1-9535-0b0e3d784eb6@linaro.org>
> Given this has been broken for a little while, and given Alan's patch fixes the problem for arm/aarch64 sims (from what I tested), can we push this for now and get it addressed in some other way later, if someone wants it?
>
> I think someone's hit this on riscv as well.
It's fixed now with Alan's patch:
commit 57ae980e3290c0c1a9fb4a93144cc5b24457f05a
Author: Alan Modra <amodra@gmail.com>
Date: Wed Mar 31 10:02:08 2021 +1030
Include string.h in bfd.h and delete LITMEMCPY, LITSTRCPY
This fixes the issue that startswith depends on strncpy being
declared, and not all projects using bfd.h include string.h before
bfd.h. I've also deleted some macros that don't find much use
anywhere.
bfd/
* bfd-in.h: Include string.h.
(LITMEMCPY, LITSTRCPY): Delete.
* bfd-in2.h: Regenerate.
binutils/
* prdbg.c (pr_function_type): Replace LITSTTCPY with strcpy.
Cheers,
Martin
next prev parent reply other threads:[~2021-03-31 13:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4d8880dd-4a83-f0fc-dafd-2079493d4093@suse.cz>
[not found] ` <alpine.BSF.2.20.16.2103181426260.908@arjuna.pair.com>
[not found] ` <20210319063759.GM6791@bubble.grove.modra.org>
[not found] ` <b0e46fde-465a-8884-d3e7-2c441a4a62c1@suse.cz>
2021-03-20 7:00 ` Alan Modra via Gdb-patches
2021-03-20 18:58 ` Tom Tromey
2021-03-21 13:12 ` Alan Modra via Gdb-patches
2021-03-22 2:13 ` Tom Tromey
2021-03-22 12:06 ` Alan Modra via Gdb-patches
2021-03-22 16:13 ` Luis Machado via Gdb-patches
2021-03-22 22:56 ` Alan Modra via Gdb-patches
2021-03-25 10:53 ` Luis Machado via Gdb-patches
2021-03-25 11:54 ` Alan Modra via Gdb-patches
2021-03-25 12:05 ` Luis Machado via Gdb-patches
2021-03-25 19:47 ` Luis Machado via Gdb-patches
2021-03-25 22:31 ` Mike Frysinger via Gdb-patches
2021-03-26 11:44 ` Luis Machado via Gdb-patches
2021-03-30 11:58 ` Luis Machado via Gdb-patches
2021-03-31 13:12 ` Martin Liška [this message]
2021-03-31 13:44 ` Luis Machado via Gdb-patches
2021-03-22 16:42 ` Martin Liška
2021-03-23 0:02 ` Alan Modra via Gdb-patches
2021-03-23 4:49 ` Mike Frysinger via Gdb-patches
2021-03-31 20:18 ` Tom Tromey
2021-03-22 6:57 ` Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f4d5d6-f3d7-6884-be78-a458beac9c28@suse.cz \
--to=mliska@suse.cz \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=thomas@t-8ch.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox