From: Alan Modra via Gdb-patches <gdb-patches@sourceware.org>
To: Luis Machado <luis.machado@linaro.org>
Cc: Tom Tromey <tom@tromey.com>,
Alan Modra via Binutils <binutils@sourceware.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ.
Date: Thu, 25 Mar 2021 22:24:13 +1030 [thread overview]
Message-ID: <20210325115413.GB5425@bubble.grove.modra.org> (raw)
In-Reply-To: <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org>
On Thu, Mar 25, 2021 at 07:53:04AM -0300, Luis Machado wrote:
> On 3/22/21 7:56 PM, Alan Modra wrote:
> > On Mon, Mar 22, 2021 at 01:13:00PM -0300, Luis Machado wrote:
> > > Just FTR, I'm seeing breakage in sim/aarch64 and sim/arm. Both are
> > > complaining about "-Werror=implicit-function-declaration" regarding strncmp
> > > and strlen.
> > >
> > > Is this the breakage you're talking about? Just so I know what to expect
> > > when it gets fixed.
> >
> > Yes.
> >
>
> Thanks. Are there plans to address this or should I come up with a patch?
I posted a patch here
https://sourceware.org/pipermail/binutils/2021-March/115863.html
It's been tested with gdb, sim and binutils builds.
Tom offered to solve the problem himself, so I'm waiting on that or
for someone in the gdb camp to review my patch. Since I messed this
up in the first place by taking a comment by Tom as a go-ahead rather
than first posting a patch for proper review by gdb maintainers, I'm
being a little cautious in committing the above patch.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2021-03-25 11:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4d8880dd-4a83-f0fc-dafd-2079493d4093@suse.cz>
[not found] ` <alpine.BSF.2.20.16.2103181426260.908@arjuna.pair.com>
[not found] ` <20210319063759.GM6791@bubble.grove.modra.org>
[not found] ` <b0e46fde-465a-8884-d3e7-2c441a4a62c1@suse.cz>
2021-03-20 7:00 ` Alan Modra via Gdb-patches
2021-03-20 18:58 ` Tom Tromey
2021-03-21 13:12 ` Alan Modra via Gdb-patches
2021-03-22 2:13 ` Tom Tromey
2021-03-22 12:06 ` Alan Modra via Gdb-patches
2021-03-22 16:13 ` Luis Machado via Gdb-patches
2021-03-22 22:56 ` Alan Modra via Gdb-patches
2021-03-25 10:53 ` Luis Machado via Gdb-patches
2021-03-25 11:54 ` Alan Modra via Gdb-patches [this message]
2021-03-25 12:05 ` Luis Machado via Gdb-patches
2021-03-25 19:47 ` Luis Machado via Gdb-patches
2021-03-25 22:31 ` Mike Frysinger via Gdb-patches
2021-03-26 11:44 ` Luis Machado via Gdb-patches
2021-03-30 11:58 ` Luis Machado via Gdb-patches
2021-03-31 13:12 ` Martin Liška
2021-03-31 13:44 ` Luis Machado via Gdb-patches
2021-03-22 16:42 ` Martin Liška
2021-03-23 0:02 ` Alan Modra via Gdb-patches
2021-03-23 4:49 ` Mike Frysinger via Gdb-patches
2021-03-31 20:18 ` Tom Tromey
2021-03-22 6:57 ` Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325115413.GB5425@bubble.grove.modra.org \
--to=gdb-patches@sourceware.org \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox