From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id J5+tLfB5XGDjJQAAWB0awg (envelope-from ) for ; Thu, 25 Mar 2021 07:54:24 -0400 Received: by simark.ca (Postfix, from userid 112) id AB3B51EF7C; Thu, 25 Mar 2021 07:54:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC3AF1EF5D for ; Thu, 25 Mar 2021 07:54:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0BDF38515FC; Thu, 25 Mar 2021 11:54:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0BDF38515FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616673262; bh=USKiIWkct2406wxGUqxssTghFNu8dPd5ReeUM5qCk5o=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=emRmHZzf5gwGVzBV7MeCOx8PgofG7gicP+jOVE7h6s40XYT09tUfSEgtbCi1wn5yW PdPypCr0zwD6bVvcAL4tT7kb2rxLoNVj0L3m0GhUBvQOLE0uE6r8Psvjanez66jsCa ym1NDnYbYK7vIuQ9ZlmmqXTWBFTEZedzbQdkC+WU= Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id DF26C3857C60; Thu, 25 Mar 2021 11:54:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DF26C3857C60 Received: by mail-pf1-x436.google.com with SMTP id 11so1788303pfn.9; Thu, 25 Mar 2021 04:54:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=USKiIWkct2406wxGUqxssTghFNu8dPd5ReeUM5qCk5o=; b=tOxnaWH5+oP3NLeLw4VT5mWN6va2t0YTHtyj59yDLfDu2cn1zcINQTQPNh0fsBqHzo UwenJLyxvltfNe6LfCESmjogduyGG3gc2wmfz82HT34jeqzzLjKX8IIcir8j37UeXLFS d7cBZX4bQxZAJAH1ZKWUx7UywnVLQXlNeRJwBY1eQDBPBdkJpUgzX8eY//ng5jI4tiQp 2WLIrGiDA27y9wdXn6gib/34gmaEy/vu5h9c75/LXlKtyB398bv94bv1d3BULGXqX1V1 fymvBYJZO5iLD9bimxvkHlb/pKE6yFf7O5rJqZqMmxq5OFNeFpxfgh0jZwRcEF9/GL9N p8Ig== X-Gm-Message-State: AOAM53252zjtJ+3rIvyc9PPsjb/yYb37udDOoGb/EKEGCiOhJkC96ZMT 9MSa5zCGWzzXcIALXgpb3ig= X-Google-Smtp-Source: ABdhPJzff6Y4DIKf6V2QPjLqY7gsBFjA2iBXz0kJKDsVflA9Bx43dT/B2Ec7PGQi1nEEgi7XncP8vw== X-Received: by 2002:a62:7f45:0:b029:205:9617:a819 with SMTP id a66-20020a627f450000b02902059617a819mr7571502pfd.17.1616673258833; Thu, 25 Mar 2021 04:54:18 -0700 (PDT) Received: from bubble.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id m4sm5413625pgu.4.2021.03.25.04.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 04:54:18 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id D3DAF40266; Thu, 25 Mar 2021 22:24:13 +1030 (ACDT) Date: Thu, 25 Mar 2021 22:24:13 +1030 To: Luis Machado Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. Message-ID: <20210325115413.GB5425@bubble.grove.modra.org> References: <20210319063759.GM6791@bubble.grove.modra.org> <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> <20210322225639.GY6791@bubble.grove.modra.org> <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alan Modra via Gdb-patches Reply-To: Alan Modra Cc: Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Thu, Mar 25, 2021 at 07:53:04AM -0300, Luis Machado wrote: > On 3/22/21 7:56 PM, Alan Modra wrote: > > On Mon, Mar 22, 2021 at 01:13:00PM -0300, Luis Machado wrote: > > > Just FTR, I'm seeing breakage in sim/aarch64 and sim/arm. Both are > > > complaining about "-Werror=implicit-function-declaration" regarding strncmp > > > and strlen. > > > > > > Is this the breakage you're talking about? Just so I know what to expect > > > when it gets fixed. > > > > Yes. > > > > Thanks. Are there plans to address this or should I come up with a patch? I posted a patch here https://sourceware.org/pipermail/binutils/2021-March/115863.html It's been tested with gdb, sim and binutils builds. Tom offered to solve the problem himself, so I'm waiting on that or for someone in the gdb camp to review my patch. Since I messed this up in the first place by taking a comment by Tom as a go-ahead rather than first posting a patch for proper review by gdb maintainers, I'm being a little cautious in committing the above patch. -- Alan Modra Australia Development Lab, IBM