From: Alan Modra via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>, Mike Frysinger <vapier@gentoo.org>
Cc: Alan Modra via Binutils <binutils@sourceware.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ.
Date: Mon, 22 Mar 2021 22:36:52 +1030 [thread overview]
Message-ID: <20210322120652.GV6791@bubble.grove.modra.org> (raw)
In-Reply-To: <87k0q0j5ql.fsf@tromey.com>
On Sun, Mar 21, 2021 at 08:13:06PM -0600, Tom Tromey wrote:
> Alan> Yes, the following compiles. Fortunately all gdb files that include
> Alan> gdbsupport/common-utils.h also include bfd.h by one means or another.
>
> Sorry, I misunderstood. I thought the proposal was to put the
> function in ansidecl.h.
>
> gdbserver can't generally include bfd. Maybe it works sometimes, but I
> imagine if you do a gdbserver-only build, bfd.h won't even be created.
> (At least, it shouldn't be, because gdbserver doesn't require bfd.)
>
> So I think some other approach is needed. Either ansidecl.h, or a new
> header; or rename either the BFD or GDB function and go from there.
A new header would be best, I think.
> I'm happy to implement it if you like.
Yes, that way you'll get it done properly. :) Sorry for the breakage.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2021-03-22 12:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4d8880dd-4a83-f0fc-dafd-2079493d4093@suse.cz>
[not found] ` <alpine.BSF.2.20.16.2103181426260.908@arjuna.pair.com>
[not found] ` <20210319063759.GM6791@bubble.grove.modra.org>
[not found] ` <b0e46fde-465a-8884-d3e7-2c441a4a62c1@suse.cz>
2021-03-20 7:00 ` Alan Modra via Gdb-patches
2021-03-20 18:58 ` Tom Tromey
2021-03-21 13:12 ` Alan Modra via Gdb-patches
2021-03-22 2:13 ` Tom Tromey
2021-03-22 12:06 ` Alan Modra via Gdb-patches [this message]
2021-03-22 16:13 ` Luis Machado via Gdb-patches
2021-03-22 22:56 ` Alan Modra via Gdb-patches
2021-03-25 10:53 ` Luis Machado via Gdb-patches
2021-03-25 11:54 ` Alan Modra via Gdb-patches
2021-03-25 12:05 ` Luis Machado via Gdb-patches
2021-03-25 19:47 ` Luis Machado via Gdb-patches
2021-03-25 22:31 ` Mike Frysinger via Gdb-patches
2021-03-26 11:44 ` Luis Machado via Gdb-patches
2021-03-30 11:58 ` Luis Machado via Gdb-patches
2021-03-31 13:12 ` Martin Liška
2021-03-31 13:44 ` Luis Machado via Gdb-patches
2021-03-22 16:42 ` Martin Liška
2021-03-23 0:02 ` Alan Modra via Gdb-patches
2021-03-23 4:49 ` Mike Frysinger via Gdb-patches
2021-03-31 20:18 ` Tom Tromey
2021-03-22 6:57 ` Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322120652.GV6791@bubble.grove.modra.org \
--to=gdb-patches@sourceware.org \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=tom@tromey.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox