From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QAAvO2WIWGA3GgAAWB0awg (envelope-from ) for ; Mon, 22 Mar 2021 08:07:01 -0400 Received: by simark.ca (Postfix, from userid 112) id EF18A1EF78; Mon, 22 Mar 2021 08:07:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 22A771E789 for ; Mon, 22 Mar 2021 08:07:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A8ED13858004; Mon, 22 Mar 2021 12:07:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8ED13858004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616414820; bh=9XH+g7cUgSoEARCAy27g244pL5xIzOg3Jwk8086lTuI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VLaFG5e5JKOzfXSpbhPz8AIe/hi3mP8caiXBATSQuVEgegPyWS8CsIrzDJQ2Fzm7s U4M84eU52/Qe0Um9DkKoFSJc/E2zJhIEo2C5WIn/KKr6FFaUop5d1xMvvhPhcwKXa+ yBSVzd6XKwqgs685/lUDM84qrDgYQqLJHEUahUJY= Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 69D3C3858004; Mon, 22 Mar 2021 12:06:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 69D3C3858004 Received: by mail-pl1-x633.google.com with SMTP id e14so6441833plj.2; Mon, 22 Mar 2021 05:06:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9XH+g7cUgSoEARCAy27g244pL5xIzOg3Jwk8086lTuI=; b=KIGG2n6TAX0gFxGcH3/9UN7cvMxPyByww+GQwc79yR+Oz20b/a4Gom3HLS8jg6Xnsh 7+g9qSSuU2MOOwU1F9HZVQq8kM80wUFKTRzsUTtossuhWXJGuLcbPH9g4QiHGFtX7fFi Rrx0eghDBPua8Obvc4OU3QfwZMqvTou+v1hC/DXBIIzgtuM08rlB1nT7H9o1YSGVEmMM Jl2nt0k7+QDCRxwMowptC2deTuJYcFqUhiR1tYUBOwylmHPZsDh5PdcdHyelpJmXjP0e AJqXPYoRBabFX4os28LnuukfRdJJHhBPZ0ppBszP+ynhTL0OUDYxeaL/fFfu6Oc03te+ fdRw== X-Gm-Message-State: AOAM531dhvxC9Do+B9zg1ddaWmcNLdOlCHBoIJFG6wH33JZ2gX9hkf1N 6Ke5r9WS8eFy1IBwohWsRSM= X-Google-Smtp-Source: ABdhPJyowEvPh17PEqzcrUyrAUCJ5IuDhKGd5LN4KXC8rx8TyKzaskhTsxoGCPk7oLgvsXkYmEV4oQ== X-Received: by 2002:a17:90b:2358:: with SMTP id ms24mr12849156pjb.132.1616414817496; Mon, 22 Mar 2021 05:06:57 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:785e:1d9c:e838:f11f]) by smtp.gmail.com with ESMTPSA id 80sm2027962pgg.8.2021.03.22.05.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 05:06:56 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 08A054008F; Mon, 22 Mar 2021 22:36:52 +1030 (ACDT) Date: Mon, 22 Mar 2021 22:36:52 +1030 To: Tom Tromey , Mike Frysinger Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. Message-ID: <20210322120652.GV6791@bubble.grove.modra.org> References: <4d8880dd-4a83-f0fc-dafd-2079493d4093@suse.cz> <20210319063759.GM6791@bubble.grove.modra.org> <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k0q0j5ql.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alan Modra via Gdb-patches Reply-To: Alan Modra Cc: Alan Modra via Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Sun, Mar 21, 2021 at 08:13:06PM -0600, Tom Tromey wrote: > Alan> Yes, the following compiles. Fortunately all gdb files that include > Alan> gdbsupport/common-utils.h also include bfd.h by one means or another. > > Sorry, I misunderstood. I thought the proposal was to put the > function in ansidecl.h. > > gdbserver can't generally include bfd. Maybe it works sometimes, but I > imagine if you do a gdbserver-only build, bfd.h won't even be created. > (At least, it shouldn't be, because gdbserver doesn't require bfd.) > > So I think some other approach is needed. Either ansidecl.h, or a new > header; or rename either the BFD or GDB function and go from there. A new header would be best, I think. > I'm happy to implement it if you like. Yes, that way you'll get it done properly. :) Sorry for the breakage. -- Alan Modra Australia Development Lab, IBM