From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Rob8Jjt1ZGCACgAAWB0awg (envelope-from ) for ; Wed, 31 Mar 2021 09:12:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 8F9551EE14; Wed, 31 Mar 2021 09:12:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CBB571E590 for ; Wed, 31 Mar 2021 09:12:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A62C384BC32; Wed, 31 Mar 2021 13:12:26 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 1A6523858012; Wed, 31 Mar 2021 13:12:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1A6523858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3BE9CB250; Wed, 31 Mar 2021 13:12:23 +0000 (UTC) Subject: Re: [PATCH] Add startswith function and use it instead of CONST_STRNEQ. To: Luis Machado , Alan Modra , Tom Tromey , Alan Modra via Binutils , gdb-patches@sourceware.org References: <20210320070037.GR6791@bubble.grove.modra.org> <87wnu1k5z1.fsf@tromey.com> <20210321131254.GS6791@bubble.grove.modra.org> <87k0q0j5ql.fsf@tromey.com> <20210322120652.GV6791@bubble.grove.modra.org> <20210322225639.GY6791@bubble.grove.modra.org> <0520bcb8-1945-5f0f-87d1-14785b881c45@linaro.org> <20210325115413.GB5425@bubble.grove.modra.org> <1e7e6f28-c916-f138-63c5-ca27f191f994@linaro.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Wed, 31 Mar 2021 15:12:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Given this has been broken for a little while, and given Alan's patch fixes the problem for arm/aarch64 sims (from what I tested), can we push this for now and get it addressed in some other way later, if someone wants it? > > I think someone's hit this on riscv as well. It's fixed now with Alan's patch: commit 57ae980e3290c0c1a9fb4a93144cc5b24457f05a Author: Alan Modra Date: Wed Mar 31 10:02:08 2021 +1030 Include string.h in bfd.h and delete LITMEMCPY, LITSTRCPY This fixes the issue that startswith depends on strncpy being declared, and not all projects using bfd.h include string.h before bfd.h. I've also deleted some macros that don't find much use anywhere. bfd/ * bfd-in.h: Include string.h. (LITMEMCPY, LITSTRCPY): Delete. * bfd-in2.h: Regenerate. binutils/ * prdbg.c (pr_function_type): Replace LITSTTCPY with strcpy. Cheers, Martin