From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 2/2] gdb/block: add assert in block_iterator::compunit_symtab
Date: Fri, 6 Feb 2026 14:01:38 -0500 [thread overview]
Message-ID: <f8e2b3e4-2f2d-4e39-a212-e332e66911d2@polymtl.ca> (raw)
In-Reply-To: <87o6m14ycj.fsf@tromey.com>
On 2026-02-06 11:43, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> From: Simon Marchi <simon.marchi@efficios.com>
> Simon> Verify that the compunit is only accessed when the iterator is in the
> Simon> mode where that field makes sense.
>
> Simon> We could also set compunit_symtab_ even in "single block" mode, it
> Simon> wouldn't hurt, but it would not be useful either.
>
> Thank you for doing this.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks to all, I will push both patches.
Simon
next prev parent reply other threads:[~2026-02-06 19:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 2:52 [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union simon.marchi
2026-02-06 2:52 ` [PATCH 2/2] gdb/block: add assert in block_iterator::compunit_symtab simon.marchi
2026-02-06 16:13 ` Guinevere Larsen
2026-02-06 16:36 ` Andrew Burgess
2026-02-06 16:43 ` Tom Tromey
2026-02-06 19:01 ` Simon Marchi [this message]
2026-02-06 16:08 ` [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union Guinevere Larsen
2026-02-06 18:56 ` Simon Marchi
2026-02-06 16:35 ` Andrew Burgess
2026-02-06 16:45 ` Tom Tromey
2026-02-06 18:57 ` Simon Marchi
2026-02-06 16:42 ` Tom Tromey
2026-02-06 19:01 ` Simon Marchi
2026-02-06 20:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8e2b3e4-2f2d-4e39-a212-e332e66911d2@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox