From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org,
Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union
Date: Fri, 06 Feb 2026 09:45:50 -0700 [thread overview]
Message-ID: <87jywp4y81.fsf@tromey.com> (raw)
In-Reply-To: <87qzqxde38.fsf@redhat.com> (Andrew Burgess's message of "Fri, 06 Feb 2026 16:35:55 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> simon.marchi@polymtl.ca writes:
>> From: Simon Marchi <simon.marchi@efficios.com>
>>
>> The block field is never used. The block is only used to grab a
>> reference to the mdict, which is stored in the mdict_iterator.
Andrew> Isn't there a contradiction between these two sentences? Either the
Andrew> block is not used, or it's used to access the mdict?
It's used when initializing the iterator but not afterward, so there's
no need to store it.
Tom
next prev parent reply other threads:[~2026-02-06 16:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 2:52 simon.marchi
2026-02-06 2:52 ` [PATCH 2/2] gdb/block: add assert in block_iterator::compunit_symtab simon.marchi
2026-02-06 16:13 ` Guinevere Larsen
2026-02-06 16:36 ` Andrew Burgess
2026-02-06 16:43 ` Tom Tromey
2026-02-06 19:01 ` Simon Marchi
2026-02-06 16:08 ` [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union Guinevere Larsen
2026-02-06 18:56 ` Simon Marchi
2026-02-06 16:35 ` Andrew Burgess
2026-02-06 16:45 ` Tom Tromey [this message]
2026-02-06 18:57 ` Simon Marchi
2026-02-06 16:42 ` Tom Tromey
2026-02-06 19:01 ` Simon Marchi
2026-02-06 20:23 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jywp4y81.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox