Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union

Simon Marchi
2026-02-06T20:24:42Z

On 2026-02-06 11:42, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> From: Simon Marchi <simon.marchi@efficios.com>
> Simon> The block field is never used. The block is only used to grab a
> Simon> reference to the mdict, which is stored in the mdict_iterator.
>
> Simon> Remove it and remove the union. Leave the compunit_symtab field, whose
> Simon> name unfortunately conflicts with the method.
>
> Seems reasonable to me.
>

Forgot to reply about this:

> Using an m_ name wouldn't be remiss, we have other cases where we've
> done this but where the field is still "public".

That is what I did at first, but then I thought that I should also
rename the other fields, which are also "internal", otherwise it's not
consistent... meh. I thought that it could wait until someone C++ifies
this code properly.

Simon