Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union

Tom Tromey
2026-02-06T16:43:43Z

>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:

Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> The block field is never used. The block is only used to grab a
Simon> reference to the mdict, which is stored in the mdict_iterator.

Simon> Remove it and remove the union. Leave the compunit_symtab field, whose
Simon> name unfortunately conflicts with the method.

Seems reasonable to me.

Using an m_ name wouldn't be remiss, we have other cases where we've
done this but where the field is still "public".

Simon> else
Simon> {
Simon> - iter->d.block = block;
Simon> -

I didn't look to see how the initialization is done, but I wonder if
this should assign nullptr to the compunit_symtab field.

Approved-By: Tom Tromey <tom@tromey.com>

Tom