Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union

Simon Marchi
2026-02-06T18:56:54Z

On 2026-02-06 11:08, Guinevere Larsen wrote:
> On 2/5/26 11:52 PM, simon.marchi@polymtl.ca wrote:
>> From: Simon Marchi <simon.marchi@efficios.com>
>>
>> The block field is never used. The block is only used to grab a
>> reference to the mdict, which is stored in the mdict_iterator.
>>
>> Remove it and remove the union. Leave the compunit_symtab field, whose
>> name unfortunately conflicts with the method.
>>
>> Change-Id: I09dbc42f937eaba6c70598acca8ff355c4e5bdb9
>
> This change looks harmless enough, but since I don't feel like I understand it well enough to properly review, best I can say is, no issues running the testsuite or rebuilding, so
>
> Tested-By: Guinevere Larsen <guinevere@redhat.com>

Thank you for checking.

Simon