From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mb4GJco6hmmOkywAWB0awg (envelope-from ) for ; Fri, 06 Feb 2026 14:02:34 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=FX6e3xKj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 913771E08D; Fri, 06 Feb 2026 14:02:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A3C211E08D for ; Fri, 06 Feb 2026 14:02:33 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3707E4BAD155 for ; Fri, 6 Feb 2026 19:02:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3707E4BAD155 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=FX6e3xKj Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C87304BAD155 for ; Fri, 6 Feb 2026 19:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C87304BAD155 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C87304BAD155 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770404506; cv=none; b=DB0EEEpZYDkzOVAOl6UPs/4K+BzCHcezWJ3l6s7VoK7iJMfzr05kFAKMS+LFdutvuos++u9WXEb5hiaHuHxmfFt6bHpa7KaRwY44OZNWa2/a5v5YHKMHBA+wty3MFWZnIPRYwwpeVuH/70Bdbp+ZmKGEVIov4AsIxg4NqvYYM0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770404506; c=relaxed/simple; bh=7d6xIr0+Kp4dfUS6ZFaopAjFXVNRi2RRoLbeaYNjQk8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=BHQuOkfAWkq1NQY0IfnGSxPks1URdHxr+Lh9lZkOta/xiQkQOq0PLlt9anN/mchgQlR+R+8jwpk8x252GmnEFnJo41cuwx+4lr4/eyaw8rrTiRRfRinn3Zc4DX95Lwzv/IMlKBZtITavNHcGqLOXUpE4Mbiq/1alZ2v06+nIYoY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C87304BAD155 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 616J1dmP081314 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Feb 2026 14:01:44 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 616J1dmP081314 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1770404504; bh=sDoK/POc6SsVWHfdwkX46PUMFeE0WRBveUqGd/HPZvc=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=FX6e3xKjDr1Ph/rGQG7M2jcf3zIZ80jgyGnIqF6mRNhbcvV/K8J0rAxwt5GUtzhY3 XilKkJu03cPu9Ta/QeuQukVovi9ZiiGNkkY+FgAFtQdB0xI1+ItuNLpsyAWeKyg9x9 gQ/JGACO+Eh4IVmc0o5+CzOAaw3AczHP2JKvJ5FwZ/QdQck3JOQt+moO693nq70gyf GPD5WhBWI4JleTx1E0nCB4G9aE+/Vf2RnnzpimoIfxVe7WxIsvSvGT0PeC08mUpqGB iseL4QPMoFSGfE8zgcuwF9mvPQLF8TL0/iuqLGPA0DvYhRdk+d8IKcD15pUd7rkp4J 6nZ0JPGF49xgA== Received: by simark.ca (Postfix) id E795E1E08D; Fri, 06 Feb 2026 14:01:38 -0500 (EST) Message-ID: Date: Fri, 6 Feb 2026 14:01:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb/block: add assert in block_iterator::compunit_symtab To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> <20260206025238.3467043-2-simon.marchi@polymtl.ca> <87o6m14ycj.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87o6m14ycj.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 6 Feb 2026 19:01:39 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-06 11:43, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> Verify that the compunit is only accessed when the iterator is in the > Simon> mode where that field makes sense. > > Simon> We could also set compunit_symtab_ even in "single block" mode, it > Simon> wouldn't hurt, but it would not be useful either. > > Thank you for doing this. > Approved-By: Tom Tromey > > Tom Thanks to all, I will push both patches. Simon