Re: [PATCH] Implement xfer_partial TARGET_OBJECT_SIGNAL_INFO for NetBSD

[Kamil Rytarowski <kamil@netbsd.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1441 bytes --]

On 28.07.2020 17:15, Simon Marchi wrote:
> On 2020-07-28 11:07 a.m., Kamil Rytarowski wrote:
>> This looks like a generic GDB bug wiith this arch_composite_type vs
>> arch_type. For now, I have used set_name + gdbarch_obstack_strdup.
>>
>> Feel free to fix the problem in GDB later and pass the name directly in
>> arch_composite_type.
> 
> I mean, you could easily use for now:
> 
>   arch_composite_type (..., gdbarch_obstack_strdup (name), ...);
> 
> Simon
> 

I know, I decided to go for set_name as it will be more agnostic to
further possible arch_composite_type() changes.

On 28.07.2020 17:17, Simon Marchi wrote:
> On 2020-07-28 11:04 a.m., Kamil Rytarowski wrote:
>> diff --git a/gdb/nbsd-nat.c b/gdb/nbsd-nat.c
>> index a9405ebf862..bdf3388de0b 100644
>> --- a/gdb/nbsd-nat.c
>> +++ b/gdb/nbsd-nat.c
>> @@ -845,3 +845,48 @@ nbsd_nat_target::supports_multi_process ()
>>  {
>>    return true;
>>  }
>> +
>> +/* Implement the "xfer_partial" target_ops method.  */
>> +
>> +enum target_xfer_status
>> +nbsd_nat_target::xfer_partial (enum target_object object,
>> +                               const char *annex, gdb_byte *readbuf,
>> +                               const gdb_byte *writebuf,
>> +                               ULONGEST offset, ULONGEST len,
>> +                               ULONGEST *xfered_len)
> Spaces here.


I'm going to fix this.

Is this patch good otherwise?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]