From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.netbsd.org (mail.NetBSD.org [IPv6:2001:470:a085:999::25]) by sourceware.org (Postfix) with ESMTPS id 675F6383F844 for ; Tue, 28 Jul 2020 15:20:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 675F6383F844 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=netbsd.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kamil@netbsd.org Received: from [IPv6:::1] (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id A2B8B84D76; Tue, 28 Jul 2020 15:20:13 +0000 (UTC) Subject: Re: [PATCH] Implement xfer_partial TARGET_OBJECT_SIGNAL_INFO for NetBSD To: Simon Marchi , Kamil Rytarowski , gdb-patches@sourceware.org References: <20200727074118.4030-1-n54@gmx.com> <48da991a-84ea-012f-8a6c-e21d90dcf079@simark.ca> <2ee982e9-fb65-1adc-2d4d-d5045d09c4c3@netbsd.org> <1ba798b7-5e10-ad24-bc4d-1ab05e5c58c2@simark.ca> From: Kamil Rytarowski Autocrypt: addr=kamil@netbsd.org; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCNLYW1pbCBSeXRh cm93c2tpIDxrYW1pbEBOZXRCU0Qub3JnPokCOQQTAQgAIwUCVbKF6wIbIwcLCQgHAwIBBhUI AgkKCwQWAgMBAh4BAheAAAoJEEuzCOmwLnZsrgwQAMdXTXDWkxtUciFgBnioE6hvZYOBV7Xa Gh3dwgVvS5rLwwq5ob1R9qdtCGMYxdaCAQCzo2hhUfe9ts11/Q4Pg0aDAb5CfdVVTmyvLMu+ gtK99t/sG4SfCdn8Bb8rCfRRDpkTq1cAGy6pp7rxyMrFBITTbdBWVcWdEdlMhEZtV8Z1BNDI kwEwZkYnM1UxOGW4rJNjNU+hBjNAscCTwBSbpG6NV1oBbgmgJ1PfaPCeAmGTLZyI57VLuFJy kR0Jlj8Ui7dAaJgO1WYdmvL+48s0N2QGEoHnrf50xoO34LlrIBUsCLmhtjWhZiuj0meCxNTr 5YpdBP13b2i64OCruH8/M4IO85GAIWxIMMv510rge9qSe38NHCzSmn9zcjFwVXIh9flZi7PK eqOP3yah6r1ZIBY68If/2FtvwDptUi1NHoSpN+dt0kRg26hDqMFOg+Jc6o7Wtm+3vFNDhU4I 8HkjDr62VlbHBxe6gDgVELcecWgXOydKgdrQhOPwCBJkPJigifsIz4EZQnyI3CchFja3qR9J Vo4iXwqAi6xN4RD0PS775JYDh56qUaaUsEctQ/D6Xm7Bbdv1VPlsYs/9uXxc/jWVhkd1sDn2 KZ3kv7uo04DoejVGWK9B4XEZ1ufRPzmlV0SYohX34ouLBq5Q6wbyw6+hUM+yM9RcvgkOCVgB laejuQINBFVwUF8BEAC61vNvzAAcYvkU89YoStDcGyun1ENNWpHOnuQEw613/Xgys6xZbKKa Xhee8Fiwm6FlaiYWh66Vw5cA+hMna9PDp6tZi106JnKZ9DcYxanHOCQ5V42OwUX0BDfwUIwq YgOz12Cf4pdIheVkDfiSEot3XrdI3lT8od9iWeehx5zfW77utVrWGUXkMFJKmiKzxyzjV+gF gLk2wH+L7KoYiV/MfLukLa7mTJAK4mi0sfjLStPlf5gELvPtyooKG0gs0MbDSG2qmzb1/A4Y ET8Vaa7wJulIePym+Du5TJBwptls0KEF9a04kp2Oc2zlUd/Z5z3lLBiZaXpfProbz3Ydjg4O 2+XTn+SHSq10l3agjiAkGwHH83Xnzn/clg3iTvwYgdOcwvfEnJ1FGz3DAzcBd/+IMaszJjuo dBVckt07mc97sseDjy+vIIyQGdMzDmI0U9UK7nDUFpnIfG5LYe+myBS1CgFrZAQ/WNg0j7aq CiIgbhVAOFi2sPRYlph2L8LZRUPFHLTt23vdJXdFDuKM6JSvPiDf914UpjXr/WSwT43lJzlO O3zgKGM7eclFsetDF3p0I4SVHvR7dHbIC5IHibssmk7bQgH0K1aGUX/QC18v3VY7wYYaotYH RnTiGbBGz+XxPhZYiXKQuyFu6dY3qOw/VjbsV6KVNn49z2Zg4RQV8QARAQABiQIfBBgBCAAJ BQJVcFBfAhsMAAoJEEuzCOmwLnZs9rIP/2MTyZ0252u51LFsMHa9/ylTyvl+UKq8iR852lkZ X9bH9nH4cUcen5vZo0EZI3IVOemHUq71u+DTq8PSj5vtJ0DW+sGBEbjW3Q4IjJ+96PPrlemK fYS0KWVwEzzNQLEejjduU43x83DvQ/URzSWgGnhMBqXUyJdsHyTFFNFwQ9U71gX00+wXHJyh aXRlK+7gRKtCWuNFtW/5bQXL9epxDAS0POIVAdBc1FtPLwg08Pj0KwHsGQpEr5/W8ybDtLF+ zISHIKCj1lZ8dv/7D1PmH5SEXzsv+bbzvPtb6zhoIA8HONshaG2eAYknAiCJZ0gj0npgktwc u9VkvDvHMD9+VyNzRV/M6Ak4nDeEG6QecTPv8IqCcAHDI27nY/49BvFVOJOMwqbTp5Xvfa71 ksP1mARrN+bIYMfOy7OhfCxGeZydvBhgCLKdL698aXmgy0xrmrOw+GXO69GVcebOvxWMXxz1 FOG/JnLIe1ZgCo2YF5wy8zTCGKCMx6gAwnku2nJmDGNsePVedV00FmB8mQ7Oxz+3B9+LtFim FHHR33PlRnViXlG+XTm9NontiGE0LvG4TzIY5CYNSw8PBao795dQMSsmMI4FHlvTIgupE9g1 PQWP+2H2C0RtnLUanRNUGRkze1+MNG7jc+fqJIo5s7+PSs26rUvA38QzEOJ95k7hdJty Message-ID: Date: Tue, 28 Jul 2020 17:17:47 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1ba798b7-5e10-ad24-bc4d-1ab05e5c58c2@simark.ca> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TBITfQbiRPNOfLHtPKJNiW99LkRhRMD8b" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 15:20:16 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TBITfQbiRPNOfLHtPKJNiW99LkRhRMD8b Content-Type: multipart/mixed; boundary="kyDUnbjC8y8QznLvz4T5DVmGobPsfJrek"; protected-headers="v1" From: Kamil Rytarowski To: Simon Marchi , Kamil Rytarowski , gdb-patches@sourceware.org Message-ID: Subject: Re: [PATCH] Implement xfer_partial TARGET_OBJECT_SIGNAL_INFO for NetBSD References: <20200727074118.4030-1-n54@gmx.com> <48da991a-84ea-012f-8a6c-e21d90dcf079@simark.ca> <2ee982e9-fb65-1adc-2d4d-d5045d09c4c3@netbsd.org> <1ba798b7-5e10-ad24-bc4d-1ab05e5c58c2@simark.ca> In-Reply-To: <1ba798b7-5e10-ad24-bc4d-1ab05e5c58c2@simark.ca> --kyDUnbjC8y8QznLvz4T5DVmGobPsfJrek Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 28.07.2020 17:15, Simon Marchi wrote: > On 2020-07-28 11:07 a.m., Kamil Rytarowski wrote: >> This looks like a generic GDB bug wiith this arch_composite_type vs >> arch_type. For now, I have used set_name + gdbarch_obstack_strdup. >> >> Feel free to fix the problem in GDB later and pass the name directly i= n >> arch_composite_type. >=20 > I mean, you could easily use for now: >=20 > arch_composite_type (..., gdbarch_obstack_strdup (name), ...); >=20 > Simon >=20 I know, I decided to go for set_name as it will be more agnostic to further possible arch_composite_type() changes. On 28.07.2020 17:17, Simon Marchi wrote: > On 2020-07-28 11:04 a.m., Kamil Rytarowski wrote: >> diff --git a/gdb/nbsd-nat.c b/gdb/nbsd-nat.c >> index a9405ebf862..bdf3388de0b 100644 >> --- a/gdb/nbsd-nat.c >> +++ b/gdb/nbsd-nat.c >> @@ -845,3 +845,48 @@ nbsd_nat_target::supports_multi_process () >> { >> return true; >> } >> + >> +/* Implement the "xfer_partial" target_ops method. */ >> + >> +enum target_xfer_status >> +nbsd_nat_target::xfer_partial (enum target_object object, >> + const char *annex, gdb_byte *readbuf, >> + const gdb_byte *writebuf, >> + ULONGEST offset, ULONGEST len, >> + ULONGEST *xfered_len) > Spaces here. I'm going to fix this. Is this patch good otherwise? --kyDUnbjC8y8QznLvz4T5DVmGobPsfJrek-- --TBITfQbiRPNOfLHtPKJNiW99LkRhRMD8b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl8gQZsACgkQS7MI6bAu dmx4oxAAs5SjWQtbcXdHqbazcb2rdqetw0CyitHZVaOGg7XPr6OJ15CSkAyOeD5O rgU/QxQKSXU0uiO7DeM7XyytYz92c3eaZayxojEZTsBrqPdtUeMeIOC5pXTe9no0 ZtwqQNa8FF7Ad16Kshnyr7fws1sMpflQMcG/sEcKU3NsNF78kV2S6ndHpOnFwy2f +WUTX6TO8ZKZ6nQrpoMxSYfmEwC/orfQl29ToNmdPQ1gHNl5hKVkrlukBU5+/4cx Dx7nHdPCDlS69jV21UGiafCPc2hVy/AJKLeBIJZb5CBzg+wGzNx/RVvv8TpfEffK 9O0XdZsxnXK1ccbNq174zVC9jryhsHpbAr5YPm0Ugd+rxpK+r3oG9J3ZV3CmfWaK QhScclOE8o0z0CqQ7KqmE8HIamUeA91DoJvMgiIz0QJvsCvAxi1gpaw514Y1tLjw 1QLPVPpJIYfG4CpEnpw3o8c73QI+0bfzTTMx/pnaKhwYyOImGWRxGqwt9V9wCR9j QnSc/RvdDEE0r5+L4CkLpC1CsTCAdZJnlCMZtj+0bcz3kPh1ZuJNJippBGKz7K+5 Es5DZGfaTIo/PCXtKgzJS1dPr461eORU/d/ez2kkeSirwN9YeO+rUtIhsUgzsFfP wtqw4EC2u+999y91EQ7NHg6xnr28KMhitldkifzrcOAOWOMWc5c= =sJkS -----END PGP SIGNATURE----- --TBITfQbiRPNOfLHtPKJNiW99LkRhRMD8b--