Re: [PATCH] Implement xfer_partial TARGET_OBJECT_SIGNAL_INFO for NetBSD

[John Baldwin <jhb@FreeBSD.org>]

On 7/27/20 12:41 AM, Kamil Rytarowski wrote:
> NetBSD implementes reading and overwriting siginfo_t received by the
> tracee. With TARGET_OBJECT_SIGNAL_INFO signal information can be
> examined and modified through the special variable $_siginfo.
> 
> Implement the "get_siginfo_type" gdbarch method for NetBSD architectures.
> 
> As with Linux architectures, cache the created type in the gdbarch when it
> is first created.  Currently NetBSD uses an identical siginfo type on
> all architectures, so there is no support for architecture-specific fields.

Generally looks ok to me.

> +  /* struct _ksiginfo */
> +  ksiginfo_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
> +  ksiginfo_type->set_name (xstrdup ("_ksiginfo"));
> +  append_composite_type_field (ksiginfo_type, "_signo", int_type);
> +  append_composite_type_field (ksiginfo_type, "_code", int_type);
> +  append_composite_type_field (ksiginfo_type, "_errno", int_type);
> +  if (lp64)
> +    append_composite_type_field (ksiginfo_type, "_pad", int_type);
> +  append_composite_type_field (ksiginfo_type, "_reason", reason_type);

I was going to suggest using append_composite_type_field_aligned for
the "_reason" member, but I see in the source that _pad is explicitly
declared under #ifdef _LP64, so I think your approach here is correct
in that I think this function should strive to match the source code
declaration for siginfo_t.

-- 
John Baldwin