Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <n54@gmx.com>,
	gdb-patches@sourceware.org, jhb@FreeBSD.org
Subject: Re: [PATCH v2] Implement xfer_partial TARGET_OBJECT_SIGNAL_INFO for NetBSD
Date: Tue, 28 Jul 2020 11:17:40 -0400	[thread overview]
Message-ID: <decbff70-1764-41d4-137a-d01442fe3376@simark.ca> (raw)
In-Reply-To: <20200728150418.19720-1-n54@gmx.com>

On 2020-07-28 11:04 a.m., Kamil Rytarowski wrote:
> diff --git a/gdb/nbsd-nat.c b/gdb/nbsd-nat.c
> index a9405ebf862..bdf3388de0b 100644
> --- a/gdb/nbsd-nat.c
> +++ b/gdb/nbsd-nat.c
> @@ -845,3 +845,48 @@ nbsd_nat_target::supports_multi_process ()
>  {
>    return true;
>  }
> +
> +/* Implement the "xfer_partial" target_ops method.  */
> +
> +enum target_xfer_status
> +nbsd_nat_target::xfer_partial (enum target_object object,
> +                               const char *annex, gdb_byte *readbuf,
> +                               const gdb_byte *writebuf,
> +                               ULONGEST offset, ULONGEST len,
> +                               ULONGEST *xfered_len)

Spaces here.

Just search for "        " (8 spaces) in the files, it's quite easy to find.

If there are pre-existing offenders, you can push obvious fixes to fix them.

Simon


  reply	other threads:[~2020-07-28 15:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  7:41 [PATCH] " Kamil Rytarowski
2020-07-27 15:42 ` John Baldwin
2020-07-28 13:26 ` Simon Marchi
2020-07-28 15:07   ` Kamil Rytarowski
2020-07-28 15:15     ` Simon Marchi
2020-07-28 15:17       ` Kamil Rytarowski
2020-07-28 15:21         ` Simon Marchi
2020-07-28 15:04 ` [PATCH v2] " Kamil Rytarowski
2020-07-28 15:17   ` Simon Marchi [this message]
2020-07-28 15:58   ` [PATCH v3] " Kamil Rytarowski
2020-07-28 16:21     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=decbff70-1764-41d4-137a-d01442fe3376@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    --cc=n54@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox