From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A3148383F844 for ; Tue, 28 Jul 2020 15:17:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A3148383F844 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 490371ED00; Tue, 28 Jul 2020 11:17:46 -0400 (EDT) Subject: Re: [PATCH v2] Implement xfer_partial TARGET_OBJECT_SIGNAL_INFO for NetBSD To: Kamil Rytarowski , gdb-patches@sourceware.org, jhb@FreeBSD.org References: <20200727074118.4030-1-n54@gmx.com> <20200728150418.19720-1-n54@gmx.com> From: Simon Marchi Message-ID: Date: Tue, 28 Jul 2020 11:17:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728150418.19720-1-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 15:17:47 -0000 On 2020-07-28 11:04 a.m., Kamil Rytarowski wrote: > diff --git a/gdb/nbsd-nat.c b/gdb/nbsd-nat.c > index a9405ebf862..bdf3388de0b 100644 > --- a/gdb/nbsd-nat.c > +++ b/gdb/nbsd-nat.c > @@ -845,3 +845,48 @@ nbsd_nat_target::supports_multi_process () > { > return true; > } > + > +/* Implement the "xfer_partial" target_ops method. */ > + > +enum target_xfer_status > +nbsd_nat_target::xfer_partial (enum target_object object, > + const char *annex, gdb_byte *readbuf, > + const gdb_byte *writebuf, > + ULONGEST offset, ULONGEST len, > + ULONGEST *xfered_len) Spaces here. Just search for " " (8 spaces) in the files, it's quite easy to find. If there are pre-existing offenders, you can push obvious fixes to fix them. Simon