Re: [PATCH v2 2/2] Allow check-mark to be changed for CLI

[Simon Marchi <simark@simark.ca>]

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

On 6/11/25 10:33 AM, Simon Marchi wrote:
> On 6/11/25 9:58 AM, Tom Tromey wrote:
>> In keeping with the emojification of gdb, this patch changes the
>> default "current" marker to be a check-mark.  It adds a knob to allow
>> the character to be changed, and, as always, reverts to the old output
>> when emojis are disabled.
>>
>> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> 
> I have not read all the discussions about the choice of the character,
> but I just wanted to report that out of the box, this doesn't look very
> good for me (the width of a checkmark isn't equal to the width of a
> character).  See attached `checkmark.png`.
> 
> Are we allowed to nitpick / bikeshed on the choice of character?  My
> preference would be for something a bit more subtle, like an arrow that
> points to the selected thing.  See `arrow.png`, which uses U+27A4.  I
> find it stylish, and at least on my setup, the width is correct.
> 
> I also don't think a checkmark is "semantically" appropriate for this
> case.  In my mind, it means that something is done or has completed
> successfully.

I actually went ahead and read the thread of v1.  It was suggested to
use the non-emoji version of U+2714.  I think I still prefer the arrow
head, but I think the non-emoji U+2714 looks good too.  See attached
screenshot.

More nitpicking: perhaps the setting should be named after what its use
is, rather than what is its default appearance.  Imagine we decide to
change the selection indicator to be a duck (U+1F986) in a later
version.  Then the "set style checkmark" setting name would not make
sense anymore.  So it should perhaps be named "set style
selection-indicator" or something like that.

Simon

[-- Attachment #2: checkmark2.png --]
[-- Type: image/png, Size: 73447 bytes --]