Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 2/2] Allow check-mark to be changed for CLI
Date: Wed, 11 Jun 2025 10:33:56 -0400	[thread overview]
Message-ID: <5ddb04dd-7e7e-4aa8-8db8-2d3baac169d8@simark.ca> (raw)
In-Reply-To: <20250611-emoji-check-mark-v2-2-d299ec101650@adacore.com>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

On 6/11/25 9:58 AM, Tom Tromey wrote:
> In keeping with the emojification of gdb, this patch changes the
> default "current" marker to be a check-mark.  It adds a knob to allow
> the character to be changed, and, as always, reverts to the old output
> when emojis are disabled.
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

I have not read all the discussions about the choice of the character,
but I just wanted to report that out of the box, this doesn't look very
good for me (the width of a checkmark isn't equal to the width of a
character).  See attached `checkmark.png`.

Are we allowed to nitpick / bikeshed on the choice of character?  My
preference would be for something a bit more subtle, like an arrow that
points to the selected thing.  See `arrow.png`, which uses U+27A4.  I
find it stylish, and at least on my setup, the width is correct.

I also don't think a checkmark is "semantically" appropriate for this
case.  In my mind, it means that something is done or has completed
successfully.

Simon

[-- Attachment #2: arrow.png --]
[-- Type: image/png, Size: 110359 bytes --]

[-- Attachment #3: checkmark.png --]
[-- Type: image/png, Size: 108845 bytes --]

  reply	other threads:[~2025-06-11 14:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 13:58 [PATCH v2 0/2] Use check-mark for current row of CLI table Tom Tromey
2025-06-11 13:58 ` [PATCH v2 1/2] Introduce ui_out::field_check_mark Tom Tromey
2025-06-11 17:39   ` Kevin Buettner
2025-06-11 13:58 ` [PATCH v2 2/2] Allow check-mark to be changed for CLI Tom Tromey
2025-06-11 14:33   ` Simon Marchi [this message]
2025-06-11 14:57     ` Simon Marchi
2025-06-11 15:01     ` Eli Zaretskii
2025-06-11 15:18       ` Simon Marchi
2025-06-11 15:40         ` Eli Zaretskii
2025-06-11 17:37     ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ddb04dd-7e7e-4aa8-8db8-2d3baac169d8@simark.ca \
    --to=simark@simark.ca \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox