From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>,
Kevin Buettner <kevinb@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Subject: [PATCH v2 0/2] Use check-mark for current row of CLI table
Date: Wed, 11 Jun 2025 07:58:42 -0600 [thread overview]
Message-ID: <20250611-emoji-check-mark-v2-0-d299ec101650@adacore.com> (raw)
This series changes CLI table output to use a check mark or other
string instead of the current "*" when emoji output is enabled. The
default in this case is now a Unicode check mark symbol.
Regression tested on x86-64 Fedora 41.
Signed-off-by: Tom Tromey <tromey@adacore.com>
---
Changes in v2:
- Addressed review comments
- Changed default to heavy check mark with emoji presentation
- Link to v1: https://inbox.sourceware.org/gdb-patches/20250509-emoji-check-mark-v1-0-63b6c52411f3@adacore.com
---
Tom Tromey (2):
Introduce ui_out::field_check_mark
Allow check-mark to be changed for CLI
gdb/NEWS | 6 ++++++
gdb/ada-tasks.c | 5 +----
gdb/cli-out.c | 8 ++++++++
gdb/cli-out.h | 2 ++
gdb/cli/cli-style.c | 31 +++++++++++++++++++++++++++++++
gdb/cli/cli-style.h | 3 +++
gdb/doc/gdb.texinfo | 12 ++++++++++++
gdb/inferior.c | 6 +-----
gdb/linux-fork.c | 5 +----
gdb/progspace.c | 6 +-----
gdb/target-connection.c | 6 ++----
gdb/testsuite/gdb.base/style.exp | 4 ++++
gdb/thread.c | 6 +-----
gdb/ui-out.c | 9 +++++++++
gdb/ui-out.h | 13 +++++++++++++
15 files changed, 95 insertions(+), 27 deletions(-)
---
base-commit: e82bc90812c54d32991326cdf3be973a5784a507
change-id: 20250509-emoji-check-mark-36415e813a85
Best regards,
--
Tom Tromey <tromey@adacore.com>
next reply other threads:[~2025-06-11 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 13:58 Tom Tromey [this message]
2025-06-11 13:58 ` [PATCH v2 1/2] Introduce ui_out::field_check_mark Tom Tromey
2025-06-11 17:39 ` Kevin Buettner
2025-06-11 13:58 ` [PATCH v2 2/2] Allow check-mark to be changed for CLI Tom Tromey
2025-06-11 14:33 ` Simon Marchi
2025-06-11 14:57 ` Simon Marchi
2025-06-11 15:01 ` Eli Zaretskii
2025-06-11 15:18 ` Simon Marchi
2025-06-11 15:40 ` Eli Zaretskii
2025-06-11 17:37 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611-emoji-check-mark-v2-0-d299ec101650@adacore.com \
--to=tromey@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox