Re: [PATCH v2 2/2] Allow check-mark to be changed for CLI

[Simon Marchi <simark@simark.ca>]

On 6/11/25 11:01 AM, Eli Zaretskii wrote:
>> Date: Wed, 11 Jun 2025 10:33:56 -0400
>> Cc: Eli Zaretskii <eliz@gnu.org>
>> From: Simon Marchi <simark@simark.ca>
>>
>> I have not read all the discussions about the choice of the character,
>> but I just wanted to report that out of the box, this doesn't look very
>> good for me (the width of a checkmark isn't equal to the width of a
>> character).  See attached `checkmark.png`.
> 
> That's because this emoji (as many others) is a wide character and
> takes 2 columns on display, and GDB evidently doesn't take that into
> account in this table-like display.

Yeah, even the non-emoji versions do take up 2 columns, I'm not sure why
those don't result in the rest of the line being shifter.  I'm also
surprised that others didn't see this...

GDB uses strlen here to compute the number of spaces to print, in order
to align stuff correctly:

https://gitlab.com/gnutools/binutils-gdb/-/blob/master/gdb/cli-out.c#L147-168

So it necessarily won't play well with multi-byte characters.

> 
>> Are we allowed to nitpick / bikeshed on the choice of character?  My
>> preference would be for something a bit more subtle, like an arrow that
>> points to the selected thing.  See `arrow.png`, which uses U+27A4.  I
>> find it stylish, and at least on my setup, the width is correct.
> 
> An arrow is not a check-mark, though.

Why does it have to be a checkmark?

Simon