Re: [PATCH v4 1/4] Fix styles in aix-thread.c to follow GNU style code.

[Simon Marchi <simon.marchi@polymtl.ca>]

On 10/5/26 2:54 PM, Aditya Kamath wrote:
> Hi Simon,
> 
> Thank you for the update. I have made the changes as per your suggestion. Sending a v5 version of the same.
> 
>>There are still many formatting problems in the file (bad alignment,
>>missing space, etc), so if we're doing this change we might as well do
>>it right.  I would suggest running clang-format on the whole file.
>>There will be a lot of unwanted changes, but also a lot of good ones.
>>Using an interactive diff tool (like meld), you can easily pick the
>>changes you want and revert those you don't want.
> 
> We do not have meld on AIX but that is okay. Ran 
> /home/clang+llvm-23.1.2-powerpc64-ibm-aix-7.2/bin/clang-format -style=GNU -i gdb/aix-thread.c
> 
> And then made changes manually, then tested.
> 
> Thanks for the suggestion. It was pretty useful. 

Btw, if you have it in your clang installation, another useful tool is
git-clang-format.  It allows you to ask clang-format to reformat only
the lines you touched in a given commit.  This helps to quickly verify
the formatting of a given patch.  Again, not all changes made by
clang-format are good for us, so you then have to manually accept or
reject the changes it did.

Simon