Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aditya Kamath <Aditya.Kamath1@ibm.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	Aditya Vidyadhar Kamath <akamath996@gmail.com>,
	Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
	"tom@tromey.com" <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>
Subject: RE: [PATCH v4 1/4] Fix styles in aix-thread.c to follow GNU style code.
Date: Mon, 5 Oct 2026 18:54:47 +0000	[thread overview]
Message-ID: <DSWPR15MB3198179BD29A03A8661B1AD3A8D6962@DSWPR15MB319817.namprd15.prod.outlook.com> (raw)
In-Reply-To: <918eb5d7-01d3-4ec1-9d8d-3b99242d290d@polymtl.ca>

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

Hi Simon,

Thank you for the update. I have made the changes as per your suggestion. Sending a v5 version of the same.

>There are still many formatting problems in the file (bad alignment,
>missing space, etc), so if we're doing this change we might as well do
>it right.  I would suggest running clang-format on the whole file.
>There will be a lot of unwanted changes, but also a lot of good ones.
>Using an interactive diff tool (like meld), you can easily pick the
>changes you want and revert those you don't want.

We do not have meld on AIX but that is okay. Ran
/home/clang+llvm-23.1.2-powerpc64-ibm-aix-7.2/bin/clang-format -style=GNU -i gdb/aix-thread.c

And then made changes manually, then tested.

Thanks for the suggestion. It was pretty useful.

Have a nice day ahead.

Regards,
Aditya.



[-- Attachment #2: Type: text/html, Size: 3025 bytes --]

  reply	other threads:[~2026-10-05 18:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 11:44 Aditya Vidyadhar Kamath
2026-10-05 14:06 ` Simon Marchi
2026-10-05 17:16   ` Aditya Kamath
2026-10-05 17:28     ` Aditya Kamath
2026-10-05 17:35       ` Simon Marchi
2026-10-05 14:19 ` Simon Marchi
2026-10-05 18:54   ` Aditya Kamath [this message]
2026-10-05 20:06     ` Simon Marchi
2026-10-06 13:23       ` Aditya Kamath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DSWPR15MB3198179BD29A03A8661B1AD3A8D6962@DSWPR15MB319817.namprd15.prod.outlook.com \
    --to=aditya.kamath1@ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox