Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Aditya Vidyadhar Kamath <akamath996@gmail.com>,
	ulrich.weigand@de.ibm.com,  tom@tromey.com
Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com,
	sangamesh.swamy@in.ibm.com
Subject: Re: [PATCH v4 1/4] Fix styles in aix-thread.c to follow GNU style code.
Date: Mon, 5 Oct 2026 10:19:49 -0400	[thread overview]
Message-ID: <918eb5d7-01d3-4ec1-9d8d-3b99242d290d@polymtl.ca> (raw)
In-Reply-To: <20261005114435.31454-2-akamath996@gmail.com>

On 10/5/26 7:44 AM, Aditya Vidyadhar Kamath wrote:
> @@ -1268,7 +1271,8 @@ supply_sprs32 (struct regcache *regcache,
>     function.  */
>  
>  static void
> -fetch_regs_user_thread (struct regcache *regcache, pthdb_pthread_t pdtid)
> +fetch_regs_user_thread (struct regcache *regcache,
> +			pthdb_pthread_t pdtid)

This didn't need to be changed.

> @@ -1630,7 +1636,8 @@ fill_sprs32 (const struct regcache *regcache,
>     but I doubt it's worth the effort.  */
>  
>  static void
> -store_regs_user_thread (const struct regcache *regcache, pthdb_pthread_t pdtid)
> +store_regs_user_thread (const struct regcache *regcache,
> +			pthdb_pthread_t pdtid)

This was fine at exactly 80 columns.

There are still many formatting problems in the file (bad alignment,
missing space, etc), so if we're doing this change we might as well do
it right.  I would suggest running clang-format on the whole file.
There will be a lot of unwanted changes, but also a lot of good ones.
Using an interactive diff tool (like meld), you can easily pick the
changes you want and revert those you don't want.

Simon

  parent reply	other threads:[~2026-10-05 14:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 11:44 Aditya Vidyadhar Kamath
2026-10-05 14:06 ` Simon Marchi
2026-10-05 17:16   ` Aditya Kamath
2026-10-05 17:28     ` Aditya Kamath
2026-10-05 17:35       ` Simon Marchi
2026-10-05 14:19 ` Simon Marchi [this message]
2026-10-05 18:54   ` Aditya Kamath
2026-10-05 20:06     ` Simon Marchi
2026-10-06 13:23       ` Aditya Kamath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=918eb5d7-01d3-4ec1-9d8d-3b99242d290d@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=Aditya.Kamath1@ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=tom@tromey.com \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox