From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NYS0BSqyw2oA2jwAWB0awg (envelope-from ) for ; Mon, 05 Oct 2026 10:20:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=Btp0ch9S; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0141D1E04E; Mon, 05 Oct 2026 10:20:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8ACA41E04E for ; Mon, 05 Oct 2026 10:20:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89AAC4BA9034 for ; Mon, 5 Oct 2026 14:20:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89AAC4BA9034 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=Btp0ch9S Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 307584BA903A for ; Mon, 5 Oct 2026 14:20:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 307584BA903A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 307584BA903A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791210001; cv=none; b=LQ6WPyYJTqt6NVqcaQCivPkLR++hnDeFEgb+zbd9MDybS9AWQh08JeFgcjF53Ahg3DgFvVtx087qb+IEzAjnIoSZB+j684dsWmVF5FhF2fi5ds6Ki7DcQcJtU1RHQ7Yznkg7afCOyMp/QldWfe5fNReNu3mmuONjaMYX5qYgycg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791210001; c=relaxed/simple; bh=lrKbRVnXivOG+Io3xhj1PTGkpsKQk9s++2NyAsOOln8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YtyTqD3TQCCAEOls7OM9cII6nywI3mysEpMXJ21zVsWSgEcvpDd4h7iXcEZUMCKOguv17MbXLX/HilHurM+/zF/RZUCgTbT04rXi6MqYxUa2/kiZ4Xi3Z9VUidcTDlLBamWnJMpocCRJgM9Okm8fBxaBQfwHpmZ0tl6LyjL0hlg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=Btp0ch9S DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 307584BA903A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 695EJoRn188618 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Oct 2026 10:19:55 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 695EJoRn188618 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1791209997; bh=BZ4PDPYH80CxOke508SvtHMovtSTx0ZceJVWQO137zw=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=Btp0ch9S6QB7VLsrW8CVot2eanPdaDXNjQp/agLiDUgcOleptoBgs/5zC25AhcHUC rPiCtVWqY25wZifd75fDccrZTFEpoVegqQ3LTeSDCVmQ8jVH3HiiFlTkDVTQhxyqYn BeK4pbQaRGubWRKfvkMPe6fUmnv14Wl0a7mMVF0I6CNKM+htQIooRwCqsBfgVN9La0 AT/0GpzPQ9kbcopESV0TsHWiE1zpqPSiZPRXmIPg9ZYc70yk0OZJS7KLrMThhuIHVY 5GDCoVR5hRN+hufic7J9TYm4XbyvaIoQUoca8Mkzk6t8HPp2Vk31FrY9Gwo3wWIsdV A0mZbFHqzFW5g== Received: by simark.ca (Postfix) id 701AD1E04E; Mon, 05 Oct 2026 10:19:50 -0400 (EDT) Message-ID: <918eb5d7-01d3-4ec1-9d8d-3b99242d290d@polymtl.ca> Date: Mon, 5 Oct 2026 10:19:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] Fix styles in aix-thread.c to follow GNU style code. To: Aditya Vidyadhar Kamath , ulrich.weigand@de.ibm.com, tom@tromey.com Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com References: <20261005114435.31454-2-akamath996@gmail.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20261005114435.31454-2-akamath996@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 5 Oct 2026 14:19:50 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/5/26 7:44 AM, Aditya Vidyadhar Kamath wrote: > @@ -1268,7 +1271,8 @@ supply_sprs32 (struct regcache *regcache, > function. */ > > static void > -fetch_regs_user_thread (struct regcache *regcache, pthdb_pthread_t pdtid) > +fetch_regs_user_thread (struct regcache *regcache, > + pthdb_pthread_t pdtid) This didn't need to be changed. > @@ -1630,7 +1636,8 @@ fill_sprs32 (const struct regcache *regcache, > but I doubt it's worth the effort. */ > > static void > -store_regs_user_thread (const struct regcache *regcache, pthdb_pthread_t pdtid) > +store_regs_user_thread (const struct regcache *regcache, > + pthdb_pthread_t pdtid) This was fine at exactly 80 columns. There are still many formatting problems in the file (bad alignment, missing space, etc), so if we're doing this change we might as well do it right. I would suggest running clang-format on the whole file. There will be a lot of unwanted changes, but also a lot of good ones. Using an interactive diff tool (like meld), you can easily pick the changes you want and revert those you don't want. Simon