From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7sikKnYDxGpZrT4AWB0awg (envelope-from ) for ; Mon, 05 Oct 2026 16:07:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=l8/OKb+P; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 98BB41E047; Mon, 05 Oct 2026 16:07:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C55DF1E047 for ; Mon, 05 Oct 2026 16:07:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 654824B9DB6F for ; Mon, 5 Oct 2026 20:07:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 654824B9DB6F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=l8/OKb+P Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E0F124B9DB4A for ; Mon, 5 Oct 2026 20:06:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0F124B9DB4A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0F124B9DB4A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791230812; cv=none; b=Tb0JSVGQY3d5jXsd80tja32h3HxnNdNYc6bhE0iCg8RUuLcvdW5a0lti16Z+SBfbkq1xnT3do9Y+OQuuiNQ23DHCE1hmXyJC4N3hZ1vaGJlJLA5NYdy9YdPlQWdARrDpkw5UkowLhOeJE2SwJvALNOYdrTuSHPARG0/589JHqjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791230812; c=relaxed/simple; bh=ahZ0NGJYz+EeNhwGD6LMbYcxn/nAHVry296IlcpIqLA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uQCWiI6wjGQ1X97zh3uDjdKnLlcYH9Pj/yejFDyYd+7PBuXlcNnWAqC3EXPMzRuyxrQHYaH5+ed+AugHFHMh0ujNI4p6GhlSuATjHnCR3boDrjj2r5oFplAKze4+Us56a+1Fck5SuQtRcE+nfb3rI/xEalZMCXN98ZNrvXgZ760= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=l8/OKb+P DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0F124B9DB4A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 695K6gDP044123 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Oct 2026 16:06:47 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 695K6gDP044123 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1791230808; bh=qzsZZGFfixNB8rucEjyt9a0rGGmYb5AQhVKEjYXu6Ho=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=l8/OKb+P4RlX0MA96MgDm114cFxnq4sct90FyKDZPDcfJXkaV4kpGVS6ZRz7jN0VU oqstrJBtdQp7rYp8cw8+917LQ164IvHR+h8bQRSE1cHudmv1o0lot4LgY85g7xDf/u 8tOCC4F7aBu6aPaGSQzO9tFBx7Iww2xxO8qxPSXUU5iZpRpOzLZUcUA9dCzKyYq4aw qZ7xTccHJlZzILErGcGhxLiLHlnmc7fIp0/CUW02pTYvkhvhQDPEzoejyT6OAMavvk lbCs9Mhf/O1Y6ilXJhFUqRHoc7nJfMEjiqrAzTHVaFqLUPCi8xSujXWi9krqQcLffK CsrbpN1AmX+5Q== Received: by simark.ca (Postfix) id 235CB1E047; Mon, 05 Oct 2026 16:06:42 -0400 (EDT) Message-ID: Date: Mon, 5 Oct 2026 16:06:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] Fix styles in aix-thread.c to follow GNU style code. To: Aditya Kamath , Aditya Vidyadhar Kamath , Ulrich Weigand , "tom@tromey.com" Cc: "gdb-patches@sourceware.org" , SANGAMESH MALLAYYA References: <20261005114435.31454-2-akamath996@gmail.com> <918eb5d7-01d3-4ec1-9d8d-3b99242d290d@polymtl.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 5 Oct 2026 20:06:42 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/5/26 2:54 PM, Aditya Kamath wrote: > Hi Simon, > > Thank you for the update. I have made the changes as per your suggestion. Sending a v5 version of the same. > >>There are still many formatting problems in the file (bad alignment, >>missing space, etc), so if we're doing this change we might as well do >>it right. I would suggest running clang-format on the whole file. >>There will be a lot of unwanted changes, but also a lot of good ones. >>Using an interactive diff tool (like meld), you can easily pick the >>changes you want and revert those you don't want. > > We do not have meld on AIX but that is okay. Ran > /home/clang+llvm-23.1.2-powerpc64-ibm-aix-7.2/bin/clang-format -style=GNU -i gdb/aix-thread.c > > And then made changes manually, then tested. > > Thanks for the suggestion. It was pretty useful. Btw, if you have it in your clang installation, another useful tool is git-clang-format. It allows you to ask clang-format to reformat only the lines you touched in a given commit. This helps to quickly verify the formatting of a given patch. Again, not all changes made by clang-format are good for us, so you then have to manually accept or reject the changes it did. Simon