* [PATCH] gdb_spawn_attach_cmdline: use unsupported instead of untested
@ 2022-04-21 8:36 Lancelot SIX via Gdb-patches
2022-04-21 13:40 ` Simon Marchi via Gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Lancelot SIX via Gdb-patches @ 2022-04-21 8:36 UTC (permalink / raw)
To: gdb-patches; +Cc: lsix, Lancelot SIX
In a previous commit (b750766ac96: gdb/testsuite: Introduce and use
gdb_spawn_attach_cmdline), if gdb_spawn_attach_cmdline cannot have GDB
attach to the process because of ptrace restrictions (operation not
permitted), the proc issues UNTESTED. This should really be
UNSUPPORTED, as it is done in gdb_attach.
This patch fixes this oversight.
Change-Id: Ib87e33b9230f3fa7a85e06220ef4c63814b71f7d
---
gdb/testsuite/lib/gdb.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 0c00d599ca5..47cb2b23676 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5205,7 +5205,7 @@ proc_with_prefix gdb_spawn_attach_cmdline { testpid } {
gdb_test_multiple "" "$test" {
-re -wrap "ptrace: Operation not permitted\\." {
- untested "$gdb_test_name (operation not permitted)"
+ unsupported "$gdb_test_name (operation not permitted)"
return 0
}
-re -wrap "ptrace: No such process\\." {
base-commit: 333cd559bae5a6be60832c020da479ae23fd2664
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gdb_spawn_attach_cmdline: use unsupported instead of untested
2022-04-21 8:36 [PATCH] gdb_spawn_attach_cmdline: use unsupported instead of untested Lancelot SIX via Gdb-patches
@ 2022-04-21 13:40 ` Simon Marchi via Gdb-patches
2022-04-21 13:42 ` Lancelot SIX via Gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi via Gdb-patches @ 2022-04-21 13:40 UTC (permalink / raw)
To: Lancelot SIX, gdb-patches; +Cc: lsix
On 2022-04-21 04:36, Lancelot SIX via Gdb-patches wrote:
> In a previous commit (b750766ac96: gdb/testsuite: Introduce and use
> gdb_spawn_attach_cmdline), if gdb_spawn_attach_cmdline cannot have GDB
> attach to the process because of ptrace restrictions (operation not
> permitted), the proc issues UNTESTED. This should really be
> UNSUPPORTED, as it is done in gdb_attach.
>
> This patch fixes this oversight.
>
> Change-Id: Ib87e33b9230f3fa7a85e06220ef4c63814b71f7d
> ---
> gdb/testsuite/lib/gdb.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 0c00d599ca5..47cb2b23676 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -5205,7 +5205,7 @@ proc_with_prefix gdb_spawn_attach_cmdline { testpid } {
>
> gdb_test_multiple "" "$test" {
> -re -wrap "ptrace: Operation not permitted\\." {
> - untested "$gdb_test_name (operation not permitted)"
> + unsupported "$gdb_test_name (operation not permitted)"
> return 0
> }
> -re -wrap "ptrace: No such process\\." {
>
> base-commit: 333cd559bae5a6be60832c020da479ae23fd2664
> --
> 2.25.1
>
This makes sense, please push, thanks.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-21 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 8:36 [PATCH] gdb_spawn_attach_cmdline: use unsupported instead of untested Lancelot SIX via Gdb-patches
2022-04-21 13:40 ` Simon Marchi via Gdb-patches
2022-04-21 13:42 ` Lancelot SIX via Gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox