Re: [PATCH] gdb_spawn_attach_cmdline: use unsupported instead of untested

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2022-04-21 04:36, Lancelot SIX via Gdb-patches wrote:
> In a previous commit (b750766ac96: gdb/testsuite: Introduce and use
> gdb_spawn_attach_cmdline), if gdb_spawn_attach_cmdline cannot have GDB
> attach to the process because of ptrace restrictions (operation not
> permitted), the proc issues UNTESTED.  This should really be
> UNSUPPORTED, as it is done in gdb_attach.
> 
> This patch fixes this oversight.
> 
> Change-Id: Ib87e33b9230f3fa7a85e06220ef4c63814b71f7d
> ---
>  gdb/testsuite/lib/gdb.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 0c00d599ca5..47cb2b23676 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -5205,7 +5205,7 @@ proc_with_prefix gdb_spawn_attach_cmdline { testpid } {
>  
>      gdb_test_multiple "" "$test" {
>  	-re -wrap "ptrace: Operation not permitted\\." {
> -	    untested "$gdb_test_name (operation not permitted)"
> +	    unsupported "$gdb_test_name (operation not permitted)"
>  	    return 0
>  	}
>  	-re -wrap "ptrace: No such process\\." {
> 
> base-commit: 333cd559bae5a6be60832c020da479ae23fd2664
> -- 
> 2.25.1
> 

This makes sense, please push, thanks.

Simon