From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KCDxDNReYWIzYQEAWB0awg (envelope-from ) for ; Thu, 21 Apr 2022 09:40:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 3236B1E162; Thu, 21 Apr 2022 09:40:36 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Kw+cg1q5; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C29B91E15E for ; Thu, 21 Apr 2022 09:40:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 734CF3856DFC for ; Thu, 21 Apr 2022 13:40:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 734CF3856DFC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650548435; bh=Hl+zSPp0tEgZpKOV91CRuraNnrj3ay16rhFEkrOCJnc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Kw+cg1q5/6yMouT43/DRErAiv4UbSSccDmb72OuRwPDBxct6O4QMM2A0JGT5dKQkg d4YeKYasddWKT7PhWkSxwSCnXdJCKcieW6aS+1FtdNd5YpJNU8ECUnGSsdD8EL9mg7 kHM/4Ur6v7BGmP0dg3heZ/VJ28ZsZF8r9QQPuE20= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 56DCD3857018 for ; Thu, 21 Apr 2022 13:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56DCD3857018 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E35EB1E01D; Thu, 21 Apr 2022 09:40:16 -0400 (EDT) Message-ID: Date: Thu, 21 Apr 2022 09:40:16 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] gdb_spawn_attach_cmdline: use unsupported instead of untested Content-Language: tl To: Lancelot SIX , gdb-patches@sourceware.org References: <20220421083655.48459-1-lancelot.six@amd.com> In-Reply-To: <20220421083655.48459-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: lsix@lancelotsix.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-04-21 04:36, Lancelot SIX via Gdb-patches wrote: > In a previous commit (b750766ac96: gdb/testsuite: Introduce and use > gdb_spawn_attach_cmdline), if gdb_spawn_attach_cmdline cannot have GDB > attach to the process because of ptrace restrictions (operation not > permitted), the proc issues UNTESTED. This should really be > UNSUPPORTED, as it is done in gdb_attach. > > This patch fixes this oversight. > > Change-Id: Ib87e33b9230f3fa7a85e06220ef4c63814b71f7d > --- > gdb/testsuite/lib/gdb.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 0c00d599ca5..47cb2b23676 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5205,7 +5205,7 @@ proc_with_prefix gdb_spawn_attach_cmdline { testpid } { > > gdb_test_multiple "" "$test" { > -re -wrap "ptrace: Operation not permitted\\." { > - untested "$gdb_test_name (operation not permitted)" > + unsupported "$gdb_test_name (operation not permitted)" > return 0 > } > -re -wrap "ptrace: No such process\\." { > > base-commit: 333cd559bae5a6be60832c020da479ae23fd2664 > -- > 2.25.1 > This makes sense, please push, thanks. Simon