Re: [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2/5/26 12:41 PM, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@efficios.com>
> Simon> I noticed some code in bkscm_print_block_syms_progress_smob peeking a
> Simon> bit in the implementation details of block_iterator, and doing
> Simon> essentially the same thing as the existing static function
> Simon> find_iterator_compunit_symtab.
> 
> Simon> Change find_iterator_compunit_symtab to become
> Simon> block_iterator::compunit_symtab, and use it in
> Simon> bkscm_print_block_syms_progress_smob.
> 
> Thanks.  One nit.
> 
> Simon> +/* Return the compunit over whose static or global block the iterator currently
> Simon> +   iterates.  Return nullptr is the iteration is finished.  */
> Simon> +  struct compunit_symtab *compunit_symtab () const;
> 
> Typo in the comment, s/is/if/ in the second sentence.
> 
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed the series with that fixed.

Simon