Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: simon.marchi@polymtl.ca
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 3/3] gdb/block: bool-ify some parameters
Date: Thu, 29 Jan 2026 21:55:28 -0500	[thread overview]
Message-ID: <20260130025546.322629-3-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20260130025546.322629-1-simon.marchi@polymtl.ca>

From: Simon Marchi <simon.marchi@efficios.com>

Change-Id: Ia89872ea4388c909bc2bf1eaf3bf900a68e1e53b
---
 gdb/block.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gdb/block.c b/gdb/block.c
index e61122410650..64ca59d44a1d 100644
--- a/gdb/block.c
+++ b/gdb/block.c
@@ -462,7 +462,7 @@ block_iterator::compunit_symtab () const
    iteration is complete.  */
 
 static struct symbol *
-block_iterator_step (struct block_iterator *iterator, int first)
+block_iterator_step (struct block_iterator *iterator, bool first)
 {
   struct symbol *sym;
 
@@ -503,7 +503,7 @@ block_iterator_step (struct block_iterator *iterator, int first)
 
 static struct symbol *
 block_iter_match_step (struct block_iterator *iterator,
-		       int first)
+		       bool first)
 {
   struct symbol *sym;
 
@@ -553,14 +553,14 @@ block_iterator_first (const struct block *block,
 	return mdict_iterator_first (block->multidict (),
 				     &iterator->mdict_iter);
 
-      return block_iterator_step (iterator, 1);
+      return block_iterator_step (iterator, true);
     }
 
   if (iterator->which == FIRST_LOCAL_BLOCK)
     return mdict_iter_match_first (block->multidict (), *name,
 				   &iterator->mdict_iter);
 
-  return block_iter_match_step (iterator, 1);
+  return block_iter_match_step (iterator, true);
 }
 
 /* See block.h.  */
@@ -573,13 +573,13 @@ block_iterator_next (struct block_iterator *iterator)
       if (iterator->which == FIRST_LOCAL_BLOCK)
 	return mdict_iterator_next (&iterator->mdict_iter);
 
-      return block_iterator_step (iterator, 0);
+      return block_iterator_step (iterator, false);
     }
 
   if (iterator->which == FIRST_LOCAL_BLOCK)
     return mdict_iter_match_next (*iterator->name, &iterator->mdict_iter);
 
-  return block_iter_match_step (iterator, 0);
+  return block_iter_match_step (iterator, false);
 }
 
 /* See block.h.  */
-- 
2.52.0


  parent reply	other threads:[~2026-01-30  2:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  2:55 [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator simon.marchi
2026-01-30  2:55 ` [PATCH 2/3] gdb/symtab: make compunit_symtab::includes a std::vector simon.marchi
2026-02-05 18:38   ` Tom Tromey
2026-01-30  2:55 ` simon.marchi [this message]
2026-02-03 17:36   ` [PATCH] gdb/dwarf2: don't search included symtabs recursively Simon Marchi
2026-02-05 18:53     ` Tom Tromey
2026-02-05 19:36       ` Simon Marchi
2026-02-05 18:38   ` [PATCH 3/3] gdb/block: bool-ify some parameters Tom Tromey
2026-02-05 17:41 ` [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator Tom Tromey
2026-02-05 19:33   ` Simon Marchi
2026-02-05 18:46 ` Tom Tromey
2026-02-05 19:17   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260130025546.322629-3-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox