Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org,  Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator
Date: Thu, 05 Feb 2026 10:41:55 -0700	[thread overview]
Message-ID: <875x8b6qak.fsf@tromey.com> (raw)
In-Reply-To: <20260130025546.322629-1-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 29 Jan 2026 21:55:26 -0500")

>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:

Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> I noticed some code in bkscm_print_block_syms_progress_smob peeking a
Simon> bit in the implementation details of block_iterator, and doing
Simon> essentially the same thing as the existing static function
Simon> find_iterator_compunit_symtab.

Simon> Change find_iterator_compunit_symtab to become
Simon> block_iterator::compunit_symtab, and use it in
Simon> bkscm_print_block_syms_progress_smob.

Thanks.  One nit.

Simon> +/* Return the compunit over whose static or global block the iterator currently
Simon> +   iterates.  Return nullptr is the iteration is finished.  */
Simon> +  struct compunit_symtab *compunit_symtab () const;

Typo in the comment, s/is/if/ in the second sentence.

Approved-By: Tom Tromey <tom@tromey.com>

Tom

  parent reply	other threads:[~2026-02-05 17:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  2:55 simon.marchi
2026-01-30  2:55 ` [PATCH 2/3] gdb/symtab: make compunit_symtab::includes a std::vector simon.marchi
2026-02-05 18:38   ` Tom Tromey
2026-01-30  2:55 ` [PATCH 3/3] gdb/block: bool-ify some parameters simon.marchi
2026-02-03 17:36   ` [PATCH] gdb/dwarf2: don't search included symtabs recursively Simon Marchi
2026-02-05 18:53     ` Tom Tromey
2026-02-05 19:36       ` Simon Marchi
2026-02-05 18:38   ` [PATCH 3/3] gdb/block: bool-ify some parameters Tom Tromey
2026-02-05 17:41 ` Tom Tromey [this message]
2026-02-05 19:33   ` [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator Simon Marchi
2026-02-05 18:46 ` Tom Tromey
2026-02-05 19:17   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875x8b6qak.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox