From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QX4FAJLWhGllCSoAWB0awg (envelope-from ) for ; Thu, 05 Feb 2026 12:42:42 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Q1phxukn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EC8E01E0BA; Thu, 05 Feb 2026 12:42:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 42A6B1E08D for ; Thu, 05 Feb 2026 12:42:41 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C411B4BA2E19 for ; Thu, 5 Feb 2026 17:42:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C411B4BA2E19 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Q1phxukn Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 6D4644BA23C2 for ; Thu, 5 Feb 2026 17:41:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D4644BA23C2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D4644BA23C2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770313318; cv=none; b=bHHAGuApt3DndhQJg9T9yLXt32xuD8wN+whEztJEW3CIIj/NFsSIY1mhF9oRGrmB9ECk413QPxeN0SMsEvBHc3lgvPE0iacC4W4SWfpBluKCmnVlgtR6mJHUyfIxpadCidipUQlUwTZqZxrpX150rKcfVzlvAmUfPeG49NZ4QXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770313318; c=relaxed/simple; bh=RR6a4eJ4gVdkRzuytVZREw7plG8gzOhmNc08ynBKB3A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=A34Tks1Yg5+krGt4WUFYS39WsTG3t7vZSOEUxYMUPm7rR0aDvjQnQXHpsC+rZbw75z9zjqHReZ6k8hLWAjpnlD9BFPfjh7z8AA5CyKnwIThwCvTLUlCHWZ6EpdqX0gqdw4eZWD6Y+SkWCVTBri1z/Rm3w4LUFhyl+sXZjk2TAh4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D4644BA23C2 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id o2i4vuBh7KXDJo3McvVxb9; Thu, 05 Feb 2026 17:41:58 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id o3MbvL2vVN3K1o3Mbvlpcr; Thu, 05 Feb 2026 17:41:57 +0000 X-Authority-Analysis: v=2.4 cv=UdRRSLSN c=1 sm=1 tr=0 ts=6984d665 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=69x-8_3Jf5ctHzv5oOwA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=X/ux/CDXuj9gIIo6oXmTTPI2Dxc3gV6FFIV50ocGmys=; b=Q1phxuknNC4noAO/O1DbhTH7AK OHVcf3gHLSnPaihBYxGY4u8UIIB5o1XyUc2GAdNN6FOa8+tCTkIlqYa3ZwJNUEMX7xtLeu3jsp6jq olcOjf5lvphE+0EMH1MIIpExj; Received: from 97-118-49-200.hlrn.qwest.net ([97.118.49.200]:51658 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vo3Ma-00000001qW4-4APb; Thu, 05 Feb 2026 10:41:57 -0700 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator In-Reply-To: <20260130025546.322629-1-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 29 Jan 2026 21:55:26 -0500") References: <20260130025546.322629-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 05 Feb 2026 10:41:55 -0700 Message-ID: <875x8b6qak.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.49.200 X-Source-L: No X-Exim-ID: 1vo3Ma-00000001qW4-4APb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-49-200.hlrn.qwest.net (bapiya) [97.118.49.200]:51658 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPR/m4+2etPTLeoZL1vgD6slGKntqVOIKQFzAk6zsjdUCoOeyKp9g1Yry6fuSVTc+s/QMuHJlTCoxVfprtRdafqP0jgtxS0+zdW8IAwX3h8lKIsoIVSr /hL2SXlrskhcaW/tidxG+jNQ3iafod5PfbHb93FpRwvuahHzwNk/d3rRmajT7VMOuTHJ6iYEPUllWjIBkY5ejMaIA8ldCtGRTbo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> I noticed some code in bkscm_print_block_syms_progress_smob peeking a Simon> bit in the implementation details of block_iterator, and doing Simon> essentially the same thing as the existing static function Simon> find_iterator_compunit_symtab. Simon> Change find_iterator_compunit_symtab to become Simon> block_iterator::compunit_symtab, and use it in Simon> bkscm_print_block_syms_progress_smob. Thanks. One nit. Simon> +/* Return the compunit over whose static or global block the iterator currently Simon> + iterates. Return nullptr is the iteration is finished. */ Simon> + struct compunit_symtab *compunit_symtab () const; Typo in the comment, s/is/if/ in the second sentence. Approved-By: Tom Tromey Tom