From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wk7AG7XwhGl9JyoAWB0awg (envelope-from ) for ; Thu, 05 Feb 2026 14:34:13 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=LdQ30PkX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5FD861E0BA; Thu, 05 Feb 2026 14:34:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C9E331E08D for ; Thu, 05 Feb 2026 14:34:12 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 53F354BBCD9B for ; Thu, 5 Feb 2026 19:34:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53F354BBCD9B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=LdQ30PkX Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9E5DE4BBC0EE for ; Thu, 5 Feb 2026 19:33:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E5DE4BBC0EE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E5DE4BBC0EE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770320026; cv=none; b=KD0oLGByO+FZV8rnYIbQUERx94XyEy/Q/ltae+2/wHhEalbn5rYjAn5QYZlF6Q5x071SSMQSx7S2FyjWo1hE7pfKuHvnSKYaMTLyzIhgVorMsKT+0E/i/QEmyamk/29DZEomLVyZq6lj4Nc7hFA8HvqmOBJgtAfCh6rUehSYGsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770320026; c=relaxed/simple; bh=QsuW8feYnnF65g32GCPBq+pc9YH1RZaZDihMfb62lQA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=QTxlVOl7rjupTCDOeHKKvgv7Q4EUGeYbE3HVwMA0LfuIg1dKufq884ALsAvfEv1hZ5f9LYg5vAUlVGnF75O8ZxINadhfrErf3vuc9ozD56t+RyrO50/Xj5ezQFOeiGyVAntySMA5V1Ulr/3+9Xm4E1SuukimPx54VkoJPlsma78= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E5DE4BBC0EE Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 615JXdWD201404 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Feb 2026 14:33:44 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 615JXdWD201404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1770320024; bh=Y/BW1Jaycz5LkvWY2VSd/NUWS9W158ZGtMvJWxeGQyE=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=LdQ30PkXYAA1x1Qs7OT1aA+GR7Wr5K+Eq0JOZDfOlYDOrGTDsfdXl7bzr/tAx7XxW IgkK5I6tEPs8fGtXV9+qKTk++yCBiq2OQl9ILhZqV5lD5sydpS/elO3eWYXV1aBx2w sn5TY6Nrf153FRXDto4yWx5d2eO+e++A8AFYfXdghYRnQr53drVdtYi0x31ri2I9dH SmcGW2NlPvqkh4cvzzaSJKGxgmX5JtqXQKINu5x9cNa0KbEFDe4bboTKP3rPHjSl3T NtYI9i1TYCCkVM0sV01MNG5mbZmysXrmcd4CpgaITY3kLmJVan1odgbifIfbvoqf2Q ybtpAWwgdvw2g== Received: by simark.ca (Postfix) id EDCE91E08D; Thu, 05 Feb 2026 14:33:38 -0500 (EST) Message-ID: Date: Thu, 5 Feb 2026 14:33:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/block: make find_iterator_compunit_symtab a method of block_iterator To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20260130025546.322629-1-simon.marchi@polymtl.ca> <875x8b6qak.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <875x8b6qak.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 5 Feb 2026 19:33:39 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/5/26 12:41 PM, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> I noticed some code in bkscm_print_block_syms_progress_smob peeking a > Simon> bit in the implementation details of block_iterator, and doing > Simon> essentially the same thing as the existing static function > Simon> find_iterator_compunit_symtab. > > Simon> Change find_iterator_compunit_symtab to become > Simon> block_iterator::compunit_symtab, and use it in > Simon> bkscm_print_block_syms_progress_smob. > > Thanks. One nit. > > Simon> +/* Return the compunit over whose static or global block the iterator currently > Simon> + iterates. Return nullptr is the iteration is finished. */ > Simon> + struct compunit_symtab *compunit_symtab () const; > > Typo in the comment, s/is/if/ in the second sentence. > > Approved-By: Tom Tromey > > Tom Thanks, pushed the series with that fixed. Simon