From: Simon Marchi <simon.marchi@polymtl.ca>
To: Stafford Horne <shorne@gmail.com>
Cc: GDB patches <gdb-patches@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>,
Mike Frysinger <vapier@gentoo.org>,
Peter Gavin <pgavin@gmail.com>
Subject: Re: [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])
Date: Sun, 08 Oct 2017 14:06:00 -0000 [thread overview]
Message-ID: <e757489a1343720d22d2ec33518fac4c@polymtl.ca> (raw)
In-Reply-To: <20171008122357.GA2958@lianli.shorne-pla.net>
On 2017-10-08 08:23, Stafford Horne wrote:
>> > + if (n.normal_exp < -1) /* If n looks like zero just return l. */
>> > + {
>> > + *f = *l;
>> > + return 0;
>> > + }
>> > + else if (n.class == sim_fpu_class_number
>> > + && n.normal_exp <= (NR_FRAC_GUARD)) /* If not too large round. */
>>
>> This line should be aligned with the opening parenthesis (well, one
>> char to the right).
>
> Right, that does move the comment out of the 80 char range, but just
> the
> ending '*/'. I hope thats ok.
Hmm, when I try it the trailing */ arrives right before the 80th column.
Simon
next prev parent reply other threads:[~2017-10-08 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 13:49 [PATCH v5 0/6] sim port for OpenRISC Stafford Horne
2017-10-05 13:49 ` [PATCH v5 3/6] sim: or1k: add or1k target to sim Stafford Horne
2017-10-07 21:15 ` Simon Marchi
2017-10-09 13:03 ` Stafford Horne
2017-10-09 13:33 ` Simon Marchi
2017-10-05 13:49 ` [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd]) Stafford Horne
2017-10-07 15:52 ` Simon Marchi
2017-10-08 12:24 ` Stafford Horne
2017-10-08 14:06 ` Simon Marchi [this message]
2017-10-05 13:49 ` [PATCH v5 2/6] sim: cgen: add MUL2OFSI and MUL1OFSI macros (needed for OR1K l.mul[u]) Stafford Horne
2017-10-07 16:01 ` Simon Marchi
2017-10-08 12:27 ` Stafford Horne
2017-10-05 13:50 ` [PATCH v5 6/6] sim: testsuite: add testsuite for or1k sim Stafford Horne
2017-10-05 13:57 ` [PATCH v5 0/6] sim port for OpenRISC Stafford Horne
2017-10-05 14:23 ` Stafford Horne
2017-10-09 17:00 [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd]) Doug Evans via gdb-patches
2017-10-09 17:01 Doug Evans via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e757489a1343720d22d2ec33518fac4c@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=pgavin@gmail.com \
--cc=shorne@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox