From: "Doug Evans via gdb-patches" <gdb-patches@sourceware.org>
To: Stafford Horne <shorne@gmail.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
GDB patches <gdb-patches@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>,
Mike Frysinger <vapier@gentoo.org>,
Peter Gavin <pgavin@gmail.com>
Subject: Re: [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])
Date: Mon, 09 Oct 2017 17:00:00 -0000 [thread overview]
Message-ID: <94eb2c0628d464df77055b202198@google.com> (raw)
Stafford Horne writes:
> > > + else if (n.class == sim_fpu_class_number
> > > + && n.normal_exp <= (NR_FRAC_GUARD)) /* If not too large round. */
> >
> > This line should be aligned with the opening parenthesis (well, one char to the right).
>
> Right, that does move the comment out of the 80 char range, but just the
> ending '*/'. I hope thats ok.
A common thing to do is put the comment on the preceding line.
E.g.,
else if (n.class == sim_fpu_class_number
/* If not too large round. */
&& n.normal_exp <= (NR_FRAC_GUARD))
[appropriately tabbed of course]
next reply other threads:[~2017-10-09 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 17:00 Doug Evans via gdb-patches [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-09 17:01 Doug Evans via gdb-patches
2017-10-05 13:49 [PATCH v5 0/6] sim port for OpenRISC Stafford Horne
2017-10-05 13:49 ` [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd]) Stafford Horne
2017-10-07 15:52 ` Simon Marchi
2017-10-08 12:24 ` Stafford Horne
2017-10-08 14:06 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94eb2c0628d464df77055b202198@google.com \
--to=gdb-patches@sourceware.org \
--cc=dje@google.com \
--cc=openrisc@lists.librecores.org \
--cc=pgavin@gmail.com \
--cc=shorne@gmail.com \
--cc=simon.marchi@polymtl.ca \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox