From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-142418-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 96897 invoked by alias); 9 Oct 2017 17:00:45 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 96879 invoked by uid 89); 9 Oct 2017 17:00:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=appropriately, H*MI:google, H*M:google
X-HELO: mail-pf0-f201.google.com
Received: from mail-pf0-f201.google.com (HELO mail-pf0-f201.google.com) (209.85.192.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 17:00:43 +0000
Received: by mail-pf0-f201.google.com with SMTP id b79so2874698pfk.9        for <gdb-patches@sourceware.org>; Mon, 09 Oct 2017 10:00:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:message-id:date:subject:from:to:cc;        bh=G4gIEGfc2vpH+c1xPq3VPfYg4WmOp1P1gTMVZqTq8YY=;        b=oQxIat/w9kjaOeoYeCwUFKcHa/g0Vsh8UGdyj+Z9rb6qIhprovFeSkYhc9YEL5kexs         Qo7h8+lBUYnZ72+pzLYGVfekqpZnoc1tt7IWJCWkRqiiLSXRBzIyGmB8Nlkt+fLfSNTj         W2a6D1R2O7AtmhvE+KzouZRf5EnlpLq6oi08QrXAK3e+mzdfuTKTiqH51VAm3IkP4Egs         svDZAMVf4llgQjUdPsNwsy8IEFwDH50kaVbEeJTcmx+X/e/dx7CY0HDwgHeZfgrVOvYg         rjypkVfmc7xpSugRPCcc5y3aFI2VQSYGPFoeP7/7sPOJdefj0NndcO4O7BuakoLMn08q         orOw==
X-Gm-Message-State: AMCzsaVSj5ylY50FSscIRyhB+SXW501eyQZormmNlzcsawfTZwke3Lo+	9XuxcYJEje+REOXg+LV8kL+hqvw=
X-Google-Smtp-Source: AOwi7QDrnedmI1Ii+Ukuvutb/aoRqMpiwaXlca6hgbd1cePuTa7w5x1NjR2D9AZkGUsvyh3XmhVntVI=
MIME-Version: 1.0
X-Received: by 10.37.209.197 with SMTP id i188mr188153ybg.37.1507568440849; Mon, 09 Oct 2017 10:00:40 -0700 (PDT)
Message-ID: <94eb2c0628d464df77055b202198@google.com>
Date: Mon, 09 Oct 2017 17:00:00 -0000
Subject: Re: [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd])
From: "Doug Evans via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Doug Evans <dje@google.com>
To: Stafford Horne <shorne@gmail.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, GDB patches <gdb-patches@sourceware.org>, 	Openrisc <openrisc@lists.librecores.org>, Mike Frysinger <vapier@gentoo.org>, 	Peter Gavin <pgavin@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2017-10/txt/msg00225.txt.bz2

Stafford Horne writes:
 > > > +    else if (n.class == sim_fpu_class_number
 > > > +	&& n.normal_exp <= (NR_FRAC_GUARD)) /* If not too large round.  */
 > > 
 > > This line should be aligned with the opening parenthesis (well, one char to the right).
 > 
 > Right, that does move the comment out of the 80 char range, but just the
 > ending '*/'.  I hope thats ok.

A common thing to do is put the comment on the preceding line.

E.g.,

    else if (n.class == sim_fpu_class_number
             /* If not too large round.  */
             && n.normal_exp <= (NR_FRAC_GUARD))

[appropriately tabbed of course]