From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8088 invoked by alias); 8 Oct 2017 14:06:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6434 invoked by uid 89); 8 Oct 2017 14:06:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Oct 2017 14:06:29 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v98E6Ng7018436 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 8 Oct 2017 10:06:27 -0400 Received: by simark.ca (Postfix, from userid 112) id E636A1E540; Sun, 8 Oct 2017 10:06:22 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 467C31E055; Sun, 8 Oct 2017 10:06:20 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 08 Oct 2017 14:06:00 -0000 From: Simon Marchi To: Stafford Horne Cc: GDB patches , Openrisc , Mike Frysinger , Peter Gavin Subject: Re: [PATCH v5 1/6] sim: cgen: add remainder functions (needed for OR1K lf.rem.[sd]) In-Reply-To: <20171008122357.GA2958@lianli.shorne-pla.net> References: <20171005134912.26799-1-shorne@gmail.com> <20171005134912.26799-2-shorne@gmail.com> <22127605-6ea8-05c4-03a6-cc37478bd459@polymtl.ca> <20171008122357.GA2958@lianli.shorne-pla.net> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 8 Oct 2017 14:06:23 +0000 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00161.txt.bz2 On 2017-10-08 08:23, Stafford Horne wrote: >> > + if (n.normal_exp < -1) /* If n looks like zero just return l. */ >> > + { >> > + *f = *l; >> > + return 0; >> > + } >> > + else if (n.class == sim_fpu_class_number >> > + && n.normal_exp <= (NR_FRAC_GUARD)) /* If not too large round. */ >> >> This line should be aligned with the opening parenthesis (well, one >> char to the right). > > Right, that does move the comment out of the 80 char range, but just > the > ending '*/'. I hope thats ok. Hmm, when I try it the trailing */ arrives right before the 80th column. Simon