From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix usage of inferior_ptid in two thread_alive implementations
Date: Thu, 23 Feb 2017 15:57:00 -0000 [thread overview]
Message-ID: <e6bc50948196cfee541a157e7b3ac670@polymtl.ca> (raw)
In-Reply-To: <83bmtttwai.fsf@gnu.org>
On 2017-02-22 22:34, Eli Zaretskii wrote:
>> But still it would be "more correct" to read the parameter instead
>> of the global, IMO.
>
> I didn't say anything to the contrary. I'm saying that if go32
> doesn't have this function called, I don't have to worry about the
> implications of the change.
Well, I'm saying that go32 _can_ have this function called. So you
should worry about the implications :).
Anyhow, given that go32 doesn't have multiple threads (thanks for
confirming), the patch shouldn't have any practical impact, so I've
pushed it.
Thanks,
Simon
next prev parent reply other threads:[~2017-02-23 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 21:25 Simon Marchi
2017-02-08 12:40 ` Pedro Alves
2017-02-09 16:46 ` Simon Marchi
2017-02-09 17:53 ` Pedro Alves
2017-02-09 20:47 ` Eli Zaretskii
2017-02-22 21:06 ` Simon Marchi
2017-02-23 3:36 ` Eli Zaretskii
2017-02-23 15:57 ` Simon Marchi [this message]
2017-03-29 20:30 ` John Baldwin
2017-03-30 0:51 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6bc50948196cfee541a157e7b3ac670@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox