From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126819 invoked by alias); 23 Feb 2017 15:57:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126794 invoked by uid 89); 23 Feb 2017 15:57:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=confirming, H*i:sk:83bmttt, H*f:sk:83bmttt X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 15:57:34 +0000 Received: by simark.ca (Postfix, from userid 33) id 4F6A11E80F; Thu, 23 Feb 2017 10:57:33 -0500 (EST) To: Eli Zaretskii Subject: Re: [PATCH] Fix usage of inferior_ptid in two thread_alive implementations X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Feb 2017 15:57:00 -0000 From: Simon Marchi Cc: palves@redhat.com, gdb-patches@sourceware.org In-Reply-To: <83bmtttwai.fsf@gnu.org> References: <20170207212450.2232-1-simon.marchi@ericsson.com> <0322ea0c-ce96-8b7c-5d2d-0efa87ab71ed@redhat.com> <8688edde-759a-7f84-482d-9823a8f546b3@redhat.com> <83o9yb3xdx.fsf@gnu.org> <3050e2df7823690bc1b6d77920ec1303@polymtl.ca> <83bmtttwai.fsf@gnu.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00632.txt.bz2 On 2017-02-22 22:34, Eli Zaretskii wrote: >> But still it would be "more correct" to read the parameter instead >> of the global, IMO. > > I didn't say anything to the contrary. I'm saying that if go32 > doesn't have this function called, I don't have to worry about the > implications of the change. Well, I'm saying that go32 _can_ have this function called. So you should worry about the implications :). Anyhow, given that go32 doesn't have multiple threads (thanks for confirming), the patch shouldn't have any practical impact, so I've pushed it. Thanks, Simon