Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix usage of inferior_ptid in two thread_alive  implementations
Date: Thu, 23 Feb 2017 03:36:00 -0000	[thread overview]
Message-ID: <83bmtttwai.fsf@gnu.org> (raw)
In-Reply-To: <3050e2df7823690bc1b6d77920ec1303@polymtl.ca> (message from Simon	Marchi on Wed, 22 Feb 2017 16:06:50 -0500)

> Date: Wed, 22 Feb 2017 16:06:50 -0500
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: Pedro Alves <palves@redhat.com>, simon.marchi@ericsson.com,
>  gdb-patches@sourceware.org
> 
> > Is that function even called in the go32 port?
> 
> Why wouldn't it?  For example, you could have this pseudo-stack:
> 
> #0 go32_thread_alive
> #1 target_thread_alive
> #2 thread_alive
> #3 thread_apply_all_command
> 
> If this target doesn't support multiple threads, it's possible that 
> inferior_ptid will always be equal to ptid (equal to the only existing 
> thread).

Go32 indeed doesn't support multiple threads.

> But still it would be "more correct" to read the parameter instead
> of the global, IMO.

I didn't say anything to the contrary.  I'm saying that if go32
doesn't have this function called, I don't have to worry about the
implications of the change.


  reply	other threads:[~2017-02-23  3:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 21:25 Simon Marchi
2017-02-08 12:40 ` Pedro Alves
2017-02-09 16:46   ` Simon Marchi
2017-02-09 17:53     ` Pedro Alves
2017-02-09 20:47       ` Eli Zaretskii
2017-02-22 21:06         ` Simon Marchi
2017-02-23  3:36           ` Eli Zaretskii [this message]
2017-02-23 15:57             ` Simon Marchi
2017-03-29 20:30       ` John Baldwin
2017-03-30  0:51         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bmtttwai.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox