From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix usage of inferior_ptid in two thread_alive implementations
Date: Thu, 09 Feb 2017 17:53:00 -0000 [thread overview]
Message-ID: <8688edde-759a-7f84-482d-9823a8f546b3@redhat.com> (raw)
In-Reply-To: <f20baf9481cbd876a3c87876bbe50445@polymtl.ca>
On 02/09/2017 04:46 PM, Simon Marchi wrote:
> On 2017-02-08 07:40, Pedro Alves wrote:
>> On 02/07/2017 09:24 PM, Simon Marchi wrote:
>>> While inspecting some target code, I noticed that in these two
>>> implementations of thread_alive, inferior_ptid is referenced directly
>>> instead of using the ptid passed as parameters. I guess that it is
>>> wrong, although I can't really test it in both cases.
>>
>> I can't test either, but it looks right to me.
>
> Soooo.. is this an approval :) ?
OK by the end of the week to give a chance of area
maintainers or interested folks to comment. E.g., Eli
is the go32-nat.c maintainer and I don't mean to overstep,
though that bit does look obvious to me. Mark or someone
with BSD access could want to comment on the BSD bit. The
latter you could perhaps test on the compile farm, if you
have access.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-02-09 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 21:25 Simon Marchi
2017-02-08 12:40 ` Pedro Alves
2017-02-09 16:46 ` Simon Marchi
2017-02-09 17:53 ` Pedro Alves [this message]
2017-02-09 20:47 ` Eli Zaretskii
2017-02-22 21:06 ` Simon Marchi
2017-02-23 3:36 ` Eli Zaretskii
2017-02-23 15:57 ` Simon Marchi
2017-03-29 20:30 ` John Baldwin
2017-03-30 0:51 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8688edde-759a-7f84-482d-9823a8f546b3@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox