From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27683 invoked by alias); 23 Feb 2017 03:36:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25524 invoked by uid 89); 23 Feb 2017 03:35:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=pseudostack, Hx-languages-length:931, sk:go32_th, pseudo-stack X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 03:35:04 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgkBI-00048q-GL for gdb-patches@sourceware.org; Wed, 22 Feb 2017 22:35:03 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgkBI-00048k-Dk; Wed, 22 Feb 2017 22:35:00 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3801 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cgkBH-000086-LQ; Wed, 22 Feb 2017 22:35:00 -0500 Date: Thu, 23 Feb 2017 03:36:00 -0000 Message-Id: <83bmtttwai.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <3050e2df7823690bc1b6d77920ec1303@polymtl.ca> (message from Simon Marchi on Wed, 22 Feb 2017 16:06:50 -0500) Subject: Re: [PATCH] Fix usage of inferior_ptid in two thread_alive implementations Reply-to: Eli Zaretskii References: <20170207212450.2232-1-simon.marchi@ericsson.com> <0322ea0c-ce96-8b7c-5d2d-0efa87ab71ed@redhat.com> <8688edde-759a-7f84-482d-9823a8f546b3@redhat.com> <83o9yb3xdx.fsf@gnu.org> <3050e2df7823690bc1b6d77920ec1303@polymtl.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00614.txt.bz2 > Date: Wed, 22 Feb 2017 16:06:50 -0500 > From: Simon Marchi > Cc: Pedro Alves , simon.marchi@ericsson.com, > gdb-patches@sourceware.org > > > Is that function even called in the go32 port? > > Why wouldn't it? For example, you could have this pseudo-stack: > > #0 go32_thread_alive > #1 target_thread_alive > #2 thread_alive > #3 thread_apply_all_command > > If this target doesn't support multiple threads, it's possible that > inferior_ptid will always be equal to ptid (equal to the only existing > thread). Go32 indeed doesn't support multiple threads. > But still it would be "more correct" to read the parameter instead > of the global, IMO. I didn't say anything to the contrary. I'm saying that if go32 doesn't have this function called, I don't have to worry about the implications of the change.