From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
gdb-patches@sourceware.org
Subject: Re: [RFC] Why does ui_out_field_core_addr pad with leading zeroes?
Date: Thu, 18 Mar 2010 20:49:00 -0000 [thread overview]
Message-ID: <e394668d1003181349u1778cf3dv9db070952b33c0a0@mail.gmail.com> (raw)
In-Reply-To: <201003181947.36801.pedro@codesourcery.com>
On Thu, Mar 18, 2010 at 12:47 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> Did you try grepping for other uses of ui_out_field_core_addr?
> Would other places need adjustment as well?
Before submitting the patch RFA I would indeed check for other uses.
I wasn't ready to go that far yet.
> And what about posting the before-with-no-patch-what-soever
> vs after-patch-that-aligns-right examples of "info break",
> instead of just leftalign-after-patch vs leftalign-after-patch?
As you wish.
Before, without patch:
(gdb) i b
Num Type Disp Enb Address What
2 breakpoint keep y 0x000000000040049c in main at hello.c:6
3 breakpoint keep y 0x00007ffff7acbe40 <printf>
After patch:
(gdb) i b
Num Type Disp Enb Address What
2 breakpoint keep y 0x40049c in main at hello.c:6
3 breakpoint keep y 0x7ffff7acbe40 <printf>
next prev parent reply other threads:[~2010-03-18 20:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 17:30 Doug Evans
2010-03-18 17:47 ` Pedro Alves
2010-03-18 18:23 ` Doug Evans
2010-03-18 18:58 ` Mark Kettenis
2010-03-18 19:19 ` Doug Evans
2010-03-18 19:25 ` Jan Kratochvil
2010-03-18 19:38 ` Doug Evans
2010-03-18 19:47 ` Pedro Alves
2010-03-18 20:49 ` Doug Evans [this message]
2010-03-18 19:51 ` Daniel Jacobowitz
2010-03-18 19:56 ` Pedro Alves
2010-03-18 20:03 ` Mark Kettenis
2010-03-18 20:59 ` Doug Evans
2010-03-18 17:52 ` Joel Brobecker
2010-03-18 18:52 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d1003181349u1778cf3dv9db070952b33c0a0@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox