From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5599 invoked by alias); 18 Mar 2010 20:49:54 -0000 Received: (qmail 5586 invoked by uid 22791); 18 Mar 2010 20:49:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 20:49:45 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id o2IKnhgT021103 for ; Thu, 18 Mar 2010 13:49:43 -0700 Received: from wwb29 (wwb29.prod.google.com [10.241.241.93]) by wpaz5.hot.corp.google.com with ESMTP id o2IKngsL007487 for ; Thu, 18 Mar 2010 13:49:42 -0700 Received: by wwb29 with SMTP id 29so1500147wwb.23 for ; Thu, 18 Mar 2010 13:49:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.186.138 with SMTP id w10mr282421wem.206.1268945381848; Thu, 18 Mar 2010 13:49:41 -0700 (PDT) In-Reply-To: <201003181947.36801.pedro@codesourcery.com> References: <20100318173015.6765784413@ruffy.mtv.corp.google.com> <20100318192535.GA25322@host0.dyn.jankratochvil.net> <201003181947.36801.pedro@codesourcery.com> Date: Thu, 18 Mar 2010 20:49:00 -0000 Message-ID: Subject: Re: [RFC] Why does ui_out_field_core_addr pad with leading zeroes? From: Doug Evans To: Pedro Alves Cc: Jan Kratochvil , Mark Kettenis , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00696.txt.bz2 On Thu, Mar 18, 2010 at 12:47 PM, Pedro Alves wrote: > Did you try grepping for other uses of ui_out_field_core_addr? > Would other places need adjustment as well? Before submitting the patch RFA I would indeed check for other uses. I wasn't ready to go that far yet. > And what about posting the before-with-no-patch-what-soever > vs after-patch-that-aligns-right examples of "info break", > instead of just leftalign-after-patch vs leftalign-after-patch? As you wish. Before, without patch: (gdb) i b Num Type Disp Enb Address What 2 breakpoint keep y 0x000000000040049c in main at hello.c:6 3 breakpoint keep y 0x00007ffff7acbe40 After patch: (gdb) i b Num Type Disp Enb Address What 2 breakpoint keep y 0x40049c in main at hello.c:6 3 breakpoint keep y 0x7ffff7acbe40