Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	pedro@codesourcery.com,         gdb-patches@sourceware.org
Subject: Re: [RFC] Why does ui_out_field_core_addr pad with leading zeroes?
Date: Thu, 18 Mar 2010 19:25:00 -0000	[thread overview]
Message-ID: <20100318192535.GA25322@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <e394668d1003181219p5f7a8489oca6bde6b3343e9ed@mail.gmail.com>

On Thu, 18 Mar 2010 20:19:11 +0100, Doug Evans wrote:
> Having stared at both alignments, I don't see aligning the address to
> the right as being easier to read than aligning them to the left, and
> even less so.
> 
> Right Aligned
> 
> (gdb) i b
> Num     Type           Disp Enb            Address What
> 2       breakpoint     keep y             0x40049c in main at hello.c:6
> 3       breakpoint     keep y       0x7ffff7acbe40 <printf>
> (gdb)
> 
> Left Aligned
> 
> (gdb) i b
> Num     Type           Disp Enb Address            What
> 2       breakpoint     keep y   0x40049c           in main at hello.c:6
> 3       breakpoint     keep y   0x7ffff7acbe40     <printf>
> (gdb)

I am definitely for the "Right Aligned" one and against the "Left Aligned"
one.  While analyzing various crash dumps one looks for the same last three
digits (ignoring PIC/PIE different PAGE_SIZE-aligned placement).  Also
sometimes sorting addresses from various sources by hand to find out the
memory layout and having to additionally re-align even the GDB dump itself is
not helpful.


Thanks,
Jan


  reply	other threads:[~2010-03-18 19:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 17:30 Doug Evans
2010-03-18 17:47 ` Pedro Alves
2010-03-18 18:23   ` Doug Evans
2010-03-18 18:58     ` Mark Kettenis
2010-03-18 19:19       ` Doug Evans
2010-03-18 19:25         ` Jan Kratochvil [this message]
2010-03-18 19:38           ` Doug Evans
2010-03-18 19:47             ` Pedro Alves
2010-03-18 20:49               ` Doug Evans
2010-03-18 19:51             ` Daniel Jacobowitz
2010-03-18 19:56               ` Pedro Alves
2010-03-18 20:03               ` Mark Kettenis
2010-03-18 20:59               ` Doug Evans
2010-03-18 17:52 ` Joel Brobecker
2010-03-18 18:52 ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100318192535.GA25322@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox