Re: [RFC] Why does ui_out_field_core_addr pad with leading zeroes?

[Doug Evans <dje@google.com>]

On Thu, Mar 18, 2010 at 10:47 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Thursday 18 March 2010 17:30:15, Doug Evans wrote:
>> I couldn't find an explanation of why ui_out_field_core_addr pads
>> the address with leading zeroes.
>>
>> Does anyone know?
>
> Personally, I find that zeros on the left serve as
> a hint at the largest possible address width in
> the architecture.  That'd be my educated guess.

There are other ways to find that without sacrificing readability.

> It also aids visual alignment I suppose.  Try also adding
> a breakpoint in a shared library in your example,
> and redoing `info break'. The column is presently
> aligned left.  I suspect it won't look as neat after
> your patch.

I realize that *could* happen, but since we're doing this fancy ui-out
thing, I would expect it's the job of the front end to do any desired
alignment.

For reference sake, this is what I get with my patch:

(gdb) b main
Breakpoint 2 at 0x40049c: file hello.c, line 6.
(gdb) i b
Num     Type           Disp Enb Address            What
2       breakpoint     keep y   0x40049c           in main at hello.c:6
(gdb) b printf
Breakpoint 3 at 0x7ffff7acbe40
(gdb) i b
Num     Type           Disp Enb Address            What
2       breakpoint     keep y   0x40049c           in main at hello.c:6
3       breakpoint     keep y   0x7ffff7acbe40     <printf>
(gdb)