From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] fix tkill_failed gcc warning in gdbserver
Date: Mon, 21 Dec 2009 20:36:00 -0000 [thread overview]
Message-ID: <e394668d0912211236je4c94bbt3063f9dbcaeeef6c@mail.gmail.com> (raw)
In-Reply-To: <20091221201921.GA27626@caradoc.them.org>
On Mon, Dec 21, 2009 at 12:19 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Mon, Dec 21, 2009 at 12:10:33PM -0800, Doug Evans wrote:
>> Hi.
>>
>> android doesn't have SYS_tkill but it does have __NR_tkill.
>
> Does it have the other SYS_ constants? It's a weird omission.
> Anyway, might as well use __NR_tkill unconditionally.
The next question is, does gdbserver need to check for
syscall.h/syscall() like gdb does?
Or can I just replace #ifdef SYS_tkill with #ifdef __NR_tkill.
gdbserver includes sys/syscall.h unconditionally, gdb/linux-nat.c does not.
gdb also checks for __NR_tkill in a way that works if it were an enum.
Does one need to worry about that case?
next prev parent reply other threads:[~2009-12-21 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 20:10 Doug Evans
2009-12-21 20:19 ` Daniel Jacobowitz
2009-12-21 20:23 ` Doug Evans
2009-12-21 20:36 ` Doug Evans [this message]
2009-12-21 20:49 ` Doug Evans
2009-12-21 20:55 ` Daniel Jacobowitz
2009-12-21 20:55 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0912211236je4c94bbt3063f9dbcaeeef6c@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox