From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 457 invoked by alias); 21 Dec 2009 20:36:25 -0000 Received: (qmail 443 invoked by uid 22791); 21 Dec 2009 20:36:24 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Dec 2009 20:36:20 +0000 Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) by smtp-out.google.com with ESMTP id nBLKaHf7017076 for ; Mon, 21 Dec 2009 12:36:18 -0800 Received: from ewy9 (ewy9.prod.google.com [10.241.103.9]) by spaceape14.eur.corp.google.com with ESMTP id nBLKaEg5021359 for ; Mon, 21 Dec 2009 12:36:16 -0800 Received: by ewy9 with SMTP id 9so136813ewy.31 for ; Mon, 21 Dec 2009 12:36:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.86.129 with SMTP id w1mr2645659wee.145.1261427773561; Mon, 21 Dec 2009 12:36:13 -0800 (PST) In-Reply-To: <20091221201921.GA27626@caradoc.them.org> References: <20091221201033.2B76C84412@ruffy.mtv.corp.google.com> <20091221201921.GA27626@caradoc.them.org> Date: Mon, 21 Dec 2009 20:36:00 -0000 Message-ID: Subject: Re: [patch] fix tkill_failed gcc warning in gdbserver From: Doug Evans To: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00320.txt.bz2 On Mon, Dec 21, 2009 at 12:19 PM, Daniel Jacobowitz wrote: > On Mon, Dec 21, 2009 at 12:10:33PM -0800, Doug Evans wrote: >> Hi. >> >> android doesn't have SYS_tkill but it does have __NR_tkill. > > Does it have the other SYS_ constants? =A0It's a weird omission. > Anyway, might as well use __NR_tkill unconditionally. The next question is, does gdbserver need to check for syscall.h/syscall() like gdb does? Or can I just replace #ifdef SYS_tkill with #ifdef __NR_tkill. gdbserver includes sys/syscall.h unconditionally, gdb/linux-nat.c does not. gdb also checks for __NR_tkill in a way that works if it were an enum. Does one need to worry about that case?