From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] fix tkill_failed gcc warning in gdbserver
Date: Mon, 21 Dec 2009 20:55:00 -0000 [thread overview]
Message-ID: <20091221205553.GB29538@caradoc.them.org> (raw)
In-Reply-To: <e394668d0912211248i3994aedck48638292baf5d3f9@mail.gmail.com>
On Mon, Dec 21, 2009 at 12:48:51PM -0800, Doug Evans wrote:
> How about this?
>
> 2009-12-21 Doug Evans <dje@google.com>
>
> gdb/
> * linux-nat.c (kill_lwp): Minor cleanup, move definition of
> tkill_failed into ifdef HAVE_TKILL_SYSCALL. Move setting of errno
> there too. Delete unnecessary resetting of errno after syscall.
> Minor comment changes to match gdbserver/linux-low.c:kill_lwp.
>
> gdbserver/
> * linux-low.c (kill_lwp): Use __NR_tkill instead of SYS_tkill.
> Move definition of tkill_failed to ifdef __NR_tkill to avoid gcc
> warning ifndef __NR_tkill. Move setting of errno there too.
> Delete unnecessary resetting of errno after syscall.
> Minor comment changes to match gdb/linux-nat.c:kill_lwp.
Fine with me.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-12-21 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 20:10 Doug Evans
2009-12-21 20:19 ` Daniel Jacobowitz
2009-12-21 20:23 ` Doug Evans
2009-12-21 20:36 ` Doug Evans
2009-12-21 20:49 ` Doug Evans
2009-12-21 20:55 ` Daniel Jacobowitz [this message]
2009-12-21 20:55 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221205553.GB29538@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox