Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE

["Doug Evans" <dje@google.com>]

On Jan 29, 2008 5:06 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Thu, Dec 20, 2007 at 11:40:06AM -0800, Doug Evans wrote:
> > 2007-12-20  Doug Evans  <dje@google.com>
> >
> >       PR 2384
> >       * gdbtypes.c (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> >       Return basetype, fieldno if found.  All callers updated.
> >       Don't cache TYPE_VPTR_FIELDNO, TYPE_VPTR_BASETYPE if from different
> >       objfile.
> >       * gdbtypes.h (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> >       * symfile.h (fill_in_vptr_fieldno): Delete.
> >
> >       * gdb.cp/gdb2384.exp: New file.
> >       * gdb.cp/gdb2384.cc: New file.
> >       * gdb.cp/gdb2384-base.h: New file.
> >       * gdb.cp/gdb2384-base.cc: New file.
>
> Thanks, this looks OK.  Could you please add copyright notices to the
> new test files before committing?
>
> > +gdb_start
> > +gdb_reinitialize_dir $srcdir/$subdir
> > +gdb_load ${binfile}
> > +#gdb_load_shlibs ${sofile}
>
> Why's that commented out?

Thanks.

Commenting out gdb_load_shlibs was probably a leftover from some
experimentation - I put it back.